Skip to content

Commit 1105c2a

Browse files
committed
convert bidders: improveddigital
1 parent 535ff28 commit 1105c2a

File tree

4 files changed

+6
-22
lines changed

4 files changed

+6
-22
lines changed

modules/id5IdSystem.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ export const id5IdSubmodule = {
122122
'gdpr': hasGdpr,
123123
'nbPage': incrementNb(config.params.partner),
124124
'o': 'pbjs',
125-
'rf': referer.referer,
125+
'rf': referer.topmostLocation,
126126
'top': referer.reachedTop ? 1 : 0,
127127
'u': referer.stack[0] || window.location.href,
128128
'v': '$prebid.version$'

modules/impactifyBidAdapter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ const createOpenRtbRequest = (validBidRequests, bidderRequest) => {
6565
dnt: (navigator.doNotTrack == 'yes' || navigator.doNotTrack == '1' || navigator.msDoNotTrack == '1') ? 1 : 0,
6666
language: ((navigator.language || navigator.userLanguage || '').split('-'))[0] || 'en',
6767
};
68-
request.site = {page: bidderRequest.refererInfo.referer};
68+
request.site = {page: bidderRequest.refererInfo.page};
6969

7070
// Handle privacy settings for GDPR/CCPA/COPPA
7171
let gdprApplies = 0;

modules/improvedigitalBidAdapter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -434,10 +434,10 @@ const ID_REQUEST = {
434434
request.app = app;
435435
} else {
436436
const site = {};
437-
const url = config.getConfig('pageUrl') || deepAccess(bidderRequest, 'refererInfo.referer');
437+
const url = deepAccess(bidderRequest, 'refererInfo.page');
438438
if (url) {
439439
site.page = url;
440-
site.domain = parseUrl(url).hostname;
440+
site.domain = bidderRequest.refererInfo.domain
441441
}
442442
const configSiteSettings = config.getConfig('site') || {};
443443
const fpdSiteSettings = deepAccess(bidderRequest, 'ortb2.site') || {};

test/spec/modules/improvedigitalBidAdapter_spec.js

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,8 @@ describe('Improve Digital Adapter Tests', function () {
118118
const bidderRequestReferrer = {
119119
bids: [simpleBidRequest],
120120
refererInfo: {
121-
referer: 'https://blah.com/test.html',
121+
page: 'https://blah.com/test.html',
122+
domain: 'blah.com'
122123
},
123124
};
124125

@@ -668,23 +669,6 @@ describe('Improve Digital Adapter Tests', function () {
668669
getConfigStub.restore();
669670
});
670671

671-
it('should set pageUrl as site param', function () {
672-
let getConfigStub = sinon.stub(config, 'getConfig');
673-
getConfigStub.withArgs('pageUrl').returns('https://improvidigital.com/test-page');
674-
let request = spec.buildRequests([simpleBidRequest], bidderRequestReferrer)[0];
675-
let payload = JSON.parse(request.data);
676-
expect(payload.site.page).does.exist.and.equal('https://improvidigital.com/test-page');
677-
expect(payload.site.domain).does.exist.and.equal('improvidigital.com');
678-
getConfigStub.reset();
679-
680-
getConfigStub.withArgs('pageUrl').returns(undefined);
681-
request = spec.buildRequests([simpleBidRequest], bidderRequestReferrer)[0];
682-
payload = JSON.parse(request.data);
683-
expect(payload.site.page).does.exist.and.equal('https://blah.com/test.html');
684-
expect(payload.site.domain).does.exist.and.equal('blah.com');
685-
getConfigStub.restore();
686-
});
687-
688672
it('should set site when app not available', function () {
689673
const getConfigStub = sinon.stub(config, 'getConfig');
690674
getConfigStub.withArgs('app').returns(undefined);

0 commit comments

Comments
 (0)