Skip to content

Commit 039444b

Browse files
dgirardidgirardi
committed
convert bidders: adrino
1 parent 70305f4 commit 039444b

10 files changed

+20
-34
lines changed

‎modules/adotBidAdapter.js

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -43,19 +43,6 @@ function tryParse(data) {
4343
}
4444
}
4545

46-
/**
47-
* Extract domain from given url
48-
*
49-
* @param {string} url
50-
* @returns {string|null} Extracted domain
51-
*/
52-
function extractDomainFromURL(url) {
53-
if (!url || !isStr(url)) return null;
54-
const domain = url.match(DOMAIN_REGEX);
55-
if (isArray(domain) && domain.length === 2) return domain[1];
56-
return null;
57-
}
58-
5946
/**
6047
* Create and return site OpenRtb object from given bidderRequest
6148
*
@@ -65,13 +52,13 @@ function extractDomainFromURL(url) {
6552
function getOpenRTBSiteObject(bidderRequest) {
6653
if (!bidderRequest || !bidderRequest.refererInfo) return null;
6754

68-
const domain = extractDomainFromURL(bidderRequest.refererInfo.referer);
55+
const domain = bidderRequest.refererInfo.domain;
6956
const publisherId = config.getConfig('adot.publisherId');
7057

7158
if (!domain) return null;
7259

7360
return {
74-
page: bidderRequest.refererInfo.referer,
61+
page: bidderRequest.refererInfo.page,
7562
domain: domain,
7663
name: domain,
7764
publisher: {

‎modules/adpartnerBidAdapter.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,8 @@ export const spec = {
1515
},
1616

1717
buildRequests: function (validBidRequests, bidderRequest) {
18-
let referer = window.location.href;
19-
try {
20-
referer = typeof bidderRequest.refererInfo === 'undefined'
21-
? window.top.location.href
22-
: bidderRequest.refererInfo.referer;
23-
} catch (e) {}
18+
// TODO does it make sense to fall back to window.location.href?
19+
const referer = bidderRequest?.refererInfo?.page || window.location.href;
2420

2521
let bidRequests = [];
2622
let beaconParams = {

‎modules/adplusBidAdapter.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ function createBidRequest(bid) {
127127
screenWidth: screen.width,
128128
screenHeight: screen.height,
129129
language: window.navigator.language || 'en-US',
130+
// TODO: these should probably look at refererInfo
130131
pageUrl: window.location.href,
131132
domain: window.location.hostname,
132133
referrer: window.location.referrer,

‎modules/adprimeBidAdapter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export const spec = {
5353
let winTop = window;
5454
let location;
5555
try {
56-
location = new URL(bidderRequest.refererInfo.referer)
56+
location = new URL(bidderRequest.refererInfo.page)
5757
winTop = window.top;
5858
} catch (e) {
5959
location = winTop.location;

‎modules/adrelevantisBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,8 @@ export const spec = {
127127

128128
if (bidderRequest && bidderRequest.refererInfo) {
129129
let refererinfo = {
130-
rd_ref: encodeURIComponent(bidderRequest.refererInfo.referer),
130+
// TODO: this sends everything it finds to the backend, except for canonicalUrl
131+
rd_ref: encodeURIComponent(bidderRequest.refererInfo.topmostLocation),
131132
rd_top: bidderRequest.refererInfo.reachedTop,
132133
rd_ifs: bidderRequest.refererInfo.numIframes,
133134
rd_stk: bidderRequest.refererInfo.stack.map((url) => encodeURIComponent(url)).join(',')

‎modules/adrinoBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ export const spec = {
3030
bidId: validBidRequests[i].bidId,
3131
nativeParams: validBidRequests[i].nativeParams,
3232
placementHash: validBidRequests[i].params.hash,
33-
referer: bidderRequest.refererInfo.referer,
33+
// TODO: is 'page' the right value here?
34+
referer: bidderRequest.refererInfo.page,
3435
userAgent: navigator.userAgent,
3536
}
3637

‎test/spec/modules/adotBidAdapter_spec.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe('Adot Adapter', function () {
2828
it('should build request (banner)', function () {
2929
const bidderRequestId = 'bidderRequestId';
3030
const validBidRequests = [{ bidderRequestId, mediaTypes: {} }, { bidderRequestId, bidId: 'bidId', mediaTypes: { banner: { sizes: [[300, 250]] } }, params: { placementId: 'placementId', adUnitCode: 200 } }];
31-
const bidderRequest = { position: 2, refererInfo: { referer: 'http://localhost.com' }, gdprConsent: { consentString: 'consentString', gdprApplies: true } };
31+
const bidderRequest = { position: 2, refererInfo: { page: 'http://localhost.com', domain: 'localhost.com' }, gdprConsent: { consentString: 'consentString', gdprApplies: true } };
3232

3333
const request = spec.buildRequests(validBidRequests, bidderRequest);
3434
const buildBidRequestResponse = {
@@ -48,7 +48,7 @@ describe('Adot Adapter', function () {
4848
bidfloor: 0
4949
}],
5050
site: {
51-
page: bidderRequest.refererInfo.referer,
51+
page: bidderRequest.refererInfo.page,
5252
domain: 'localhost.com',
5353
name: 'localhost.com',
5454
publisher: {
@@ -76,7 +76,7 @@ describe('Adot Adapter', function () {
7676
it('should build request (native)', function () {
7777
const bidderRequestId = 'bidderRequestId';
7878
const validBidRequests = [{ bidderRequestId, mediaTypes: {} }, { bidderRequestId, bidId: 'bidId', mediaTypes: { native: { title: { required: true, len: 50, sizes: [[300, 250]] }, wrong: {}, image: {} } }, params: { placementId: 'placementId', adUnitCode: 200 } }];
79-
const bidderRequest = { position: 2, refererInfo: { referer: 'http://localhost.com' }, gdprConsent: { consentString: 'consentString', gdprApplies: true } };
79+
const bidderRequest = { position: 2, refererInfo: { page: 'http://localhost.com', domain: 'localhost.com' }, gdprConsent: { consentString: 'consentString', gdprApplies: true } };
8080

8181
const request = spec.buildRequests(validBidRequests, bidderRequest);
8282
const buildBidRequestResponse = {
@@ -95,7 +95,7 @@ describe('Adot Adapter', function () {
9595
bidfloor: 0
9696
}],
9797
site: {
98-
page: bidderRequest.refererInfo.referer,
98+
page: bidderRequest.refererInfo.page,
9999
domain: 'localhost.com',
100100
name: 'localhost.com',
101101
publisher: {
@@ -123,7 +123,7 @@ describe('Adot Adapter', function () {
123123
it('should build request (video)', function () {
124124
const bidderRequestId = 'bidderRequestId';
125125
const validBidRequests = [{ bidderRequestId, mediaTypes: {} }, { bidderRequestId, bidId: 'bidId', mediaTypes: { video: { playerSize: [[300, 250]], minduration: 1, maxduration: 2, api: 'api', linearity: 'linearity', mimes: [], placement: 'placement', playbackmethod: 'playbackmethod', protocols: 'protocol', startdelay: 'startdelay' } }, params: { placementId: 'placementId', adUnitCode: 200 } }];
126-
const bidderRequest = { position: 2, refererInfo: { referer: 'http://localhost.com' }, gdprConsent: { consentString: 'consentString', gdprApplies: true } };
126+
const bidderRequest = { position: 2, refererInfo: { page: 'http://localhost.com', domain: 'localhost.com' }, gdprConsent: { consentString: 'consentString', gdprApplies: true } };
127127

128128
const request = spec.buildRequests(validBidRequests, bidderRequest);
129129
const buildBidRequestResponse = {
@@ -154,7 +154,7 @@ describe('Adot Adapter', function () {
154154
bidfloor: 0
155155
}],
156156
site: {
157-
page: bidderRequest.refererInfo.referer,
157+
page: bidderRequest.refererInfo.page,
158158
domain: 'localhost.com',
159159
name: 'localhost.com',
160160
publisher: {

‎test/spec/modules/adpartnerBidAdapter_spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ describe('AdpartnerAdapter', function () {
8686

8787
let bidderRequest = {
8888
refererInfo: {
89-
referer: 'https://test.domain'
89+
page: 'https://test.domain'
9090
}
9191
};
9292

‎test/spec/modules/adrelevantisBidAdapter_spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ describe('AdrelevantisAdapter', function () {
445445
const bidRequest = Object.assign({}, bidRequests[0])
446446
const bidderRequest = {
447447
refererInfo: {
448-
referer: 'http://example.com/page.html',
448+
topmostLocation: 'http://example.com/page.html',
449449
reachedTop: true,
450450
numIframes: 2,
451451
stack: [

‎test/spec/modules/adrinoBidAdapter_spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ describe('adrinoBidAdapter', function () {
7575
it('should build the request correctly with gdpr', function () {
7676
const result = spec.buildRequests(
7777
[ bidRequest ],
78-
{ gdprConsent: { gdprApplies: true, consentString: 'abc123' }, refererInfo: { referer: 'http://example.com/' } }
78+
{ gdprConsent: { gdprApplies: true, consentString: 'abc123' }, refererInfo: { page: 'http://example.com/' } }
7979
);
8080
expect(result.length).to.equal(1);
8181
expect(result[0].method).to.equal('POST');
@@ -91,7 +91,7 @@ describe('adrinoBidAdapter', function () {
9191
it('should build the request correctly without gdpr', function () {
9292
const result = spec.buildRequests(
9393
[ bidRequest ],
94-
{ refererInfo: { referer: 'http://example.com/' } }
94+
{ refererInfo: { page: 'http://example.com/' } }
9595
);
9696
expect(result.length).to.equal(1);
9797
expect(result[0].method).to.equal('POST');

0 commit comments

Comments
 (0)