Skip to content

Commit 0d4f33a

Browse files
authored
Update CommandEventHandler type to use EventHandler (#4740)
Update the `CommandEventHandler` type declaration to match other `*EventHandler` types by using the `EventHandler` utility. This fixes a downstream typing error reported in hypothesis/frontend-shared#1899 (comment).
1 parent 80ca668 commit 0d4f33a

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

src/jsx.d.ts

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ interface CommandEvent extends Event {
5151

5252
declare var CommandEvent: {
5353
prototype: CommandEvent;
54-
new(type: string, eventInitDict?: CommandEventInit): CommandEvent;
54+
new (type: string, eventInitDict?: CommandEventInit): CommandEvent;
5555
};
5656

5757
interface CommandEventInit extends EventInit {
@@ -513,8 +513,10 @@ export namespace JSXInternal {
513513
TargetedEvent<Target, AnimationEvent>;
514514
export type TargetedClipboardEvent<Target extends EventTarget> =
515515
TargetedEvent<Target, ClipboardEvent>;
516-
export type TargetedCommandEvent<Target extends EventTarget> =
517-
TargetedEvent<Target, CommandEvent>;
516+
export type TargetedCommandEvent<Target extends EventTarget> = TargetedEvent<
517+
Target,
518+
CommandEvent
519+
>;
518520
export type TargetedCompositionEvent<Target extends EventTarget> =
519521
TargetedEvent<Target, CompositionEvent>;
520522
export type TargetedDragEvent<Target extends EventTarget> = TargetedEvent<
@@ -576,8 +578,9 @@ export namespace JSXInternal {
576578
export type ClipboardEventHandler<Target extends EventTarget> = EventHandler<
577579
TargetedClipboardEvent<Target>
578580
>;
579-
export type CommandEventHandler<Target extends EventTarget> =
581+
export type CommandEventHandler<Target extends EventTarget> = EventHandler<
580582
TargetedCommandEvent<Target>
583+
>;
581584
export type CompositionEventHandler<Target extends EventTarget> =
582585
EventHandler<TargetedCompositionEvent<Target>>;
583586
export type DragEventHandler<Target extends EventTarget> = EventHandler<
@@ -850,7 +853,7 @@ export namespace JSXInternal {
850853
onResize?: PictureInPictureEventHandler<Target>;
851854
onResizeCapture?: PictureInPictureEventHandler<Target>;
852855

853-
onCommand?: CommandEventHandler<Target>
856+
onCommand?: CommandEventHandler<Target>;
854857
}
855858

856859
// All the WAI-ARIA 1.1 attributes from https://www.w3.org/TR/wai-aria-1.1/
@@ -1286,8 +1289,12 @@ export namespace JSXInternal {
12861289
/** @deprecated See https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contextmenu */
12871290
contextmenu?: Signalish<string | undefined>;
12881291
controls?: Signalish<boolean | undefined>;
1289-
controlslist?: Signalish<'nodownload' | 'nofullscreen' | 'noremoteplayback' | undefined>;
1290-
controlsList?: Signalish<'nodownload' | 'nofullscreen' | 'noremoteplayback' | undefined>;
1292+
controlslist?: Signalish<
1293+
'nodownload' | 'nofullscreen' | 'noremoteplayback' | undefined
1294+
>;
1295+
controlsList?: Signalish<
1296+
'nodownload' | 'nofullscreen' | 'noremoteplayback' | undefined
1297+
>;
12911298
coords?: Signalish<string | undefined>;
12921299
crossOrigin?: Signalish<string | undefined>;
12931300
crossorigin?: Signalish<string | undefined>;

0 commit comments

Comments
 (0)