Skip to content

Commit a4968ee

Browse files
authored
fix: Ensure processing prerenderUrls fails build rather than warn (#1785)
* fix: If prerenderUrls exists but cannot be read, it should error * docs: Adding changeset
1 parent c55a69a commit a4968ee

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

.changeset/hip-pans-visit.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'preact-cli': patch
3+
---
4+
5+
If `--prerenderUrls` file exists on the disk, but it cannot be processed (thrown errors, incorrect format, etc), the build should error out rather than continue with a warning.

packages/cli/src/lib/webpack/render-html-plugin.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const HtmlWebpackExcludeAssetsPlugin = require('html-webpack-exclude-assets-plug
55
const HtmlWebpackPlugin = require('html-webpack-plugin');
66
const prerender = require('./prerender');
77
const createLoadManifest = require('./create-load-manifest');
8-
const { esmImport, tryResolveConfig, warn } = require('../../util');
8+
const { error, esmImport, tryResolveConfig, warn } = require('../../util');
99

1010
const PREACT_FALLBACK_URL = '/200.html';
1111

@@ -126,11 +126,12 @@ module.exports = async function (config) {
126126
if (Array.isArray(result)) {
127127
pages = result;
128128
}
129-
} catch (error) {
130-
warn(
131-
`Failed to load prerenderUrls file, using default!\n${
132-
config.verbose ? error.stack : error.message
133-
}`
129+
} catch (err) {
130+
error(
131+
`Failed to load prerenderUrls file!\n${
132+
config.verbose ? err.stack : err.message
133+
}`,
134+
1
134135
);
135136
}
136137
}

0 commit comments

Comments
 (0)