[dpb|config] Fix the validation logic of breakout mode (sonic-net#1440)

As per latest update in DPB DOC, fixed this bug

previously we had string value in "breakout_modes" key so it was not matching the whole string, But after the update via, now "breakout_modes" contain a dictionary where key is the breakout_mode and value is the alias. So we can easily check whether the key is present or not.

Signed-off-by: Sangita Maity <[email protected]>
Co-authored-by: Guohan Lu <[email protected]>

Author: 2 people

config/main.py

@@ -114,10 +114,8 @@ def _get_breakout_options(ctx, args, incomplete):
     else:
         breakout_file_input = readJsonFile(breakout_cfg_file)
         if interface_name in breakout_file_input[INTF_KEY]:
-            breakout_mode_list = [v["breakout_modes"] for i, v in breakout_file_input[INTF_KEY].items() if i == interface_name][0]
-            breakout_mode_options = []
-            for i in breakout_mode_list.split(','):
-                    breakout_mode_options.append(i)
+            breakout_mode_options = [mode for i, v in breakout_file_input[INTF_KEY].items() if i == interface_name \
+                                          for mode in v["breakout_modes"].keys()]
             all_mode_options = [str(c) for c in breakout_mode_options if incomplete in c]
         return all_mode_options
 
@@ -130,7 +128,7 @@ def _validate_interface_mode(ctx, breakout_cfg_file, interface_name, target_brko
         return False
 
     # Check whether target breakout mode is available for the user-selected interface or not
-    if target_brkout_mode not in breakout_file_input[interface_name]["breakout_modes"]:
+    if target_brkout_mode not in breakout_file_input[interface_name]["breakout_modes"].keys():
         click.secho('[ERROR] Target mode {} is not available for the port {}'. format(target_brkout_mode, interface_name), fg='red')
         return False
 

tests/config_dpb_test.py

@@ -22,25 +22,43 @@
             "index": "1,1,1,1",
             "lanes": "65,66,67,68",
             "alias_at_lanes": "Eth1/1, Eth1/2, Eth1/3, Eth1/4",
-            "breakout_modes": "1x100G[40G],2x50G,4x25G[10G]"
+            "breakout_modes": {
+                "1x100G[40G]": ["Eth1"],
+                "2x50G": ["Eth1/1", "Eth1/3"],
+                "4x25G[10G]": ["Eth1/1", "Eth1/2", "Eth1/3", "Eth1/4"]
+            }
         },
         "Ethernet4": {
             "index": "2,2,2,2",
             "lanes": "69,70,71,72",
             "alias_at_lanes": "Eth2/1, Eth2/2, Eth2/3, Eth2/4",
-            "breakout_modes": "1x100G[40G],2x50G,4x25G[10G],1x50G(2)+2x25G(2)"
+            "breakout_modes": {
+                "1x100G[40G]": ["Eth2"],
+                "2x50G": ["Eth2/1", "Eth2/3"],
+                "4x25G[10G]": ["Eth2/1", "Eth2/2", "Eth2/3", "Eth2/4"],
+                "1x50G(2)+2x25G(2)": ["Eth2/1", "Eth2/3", "Eth2/4"]
+            }
         },
         "Ethernet8": {
             "index": "3,3,3,3",
             "lanes": "73,74,75,76",
             "alias_at_lanes": "Eth3/1, Eth3/2, Eth3/3, Eth3/4",
-            "breakout_modes": "1x100G[40G],2x50G,4x25G[10G],1x50G(2)+2x25G(2)"
+            "breakout_modes": {
+                "1x100G[40G]": ["Eth3"],
+                "2x50G": ["Eth3/1", "Eth3/3"],
+                "4x25G[10G]": ["Eth3/1", "Eth3/2", "Eth3/3", "Eth3/4"],
+                "1x50G(2)+2x25G(2)": ["Eth3/1", "Eth3/3", "Eth3/4"]
+            }
         },
         "Ethernet12": {
             "index": "4,4,4,4",
             "lanes": "77,78,79,80",
             "alias_at_lanes": "Eth4/1, Eth4/2, Eth4/3, Eth4/4",
-            "breakout_modes": "1x100G[40G],2x50G,4x25G[10G]"
+            "breakout_modes": {
+                "1x100G[40G]": ["Eth4"],
+                "2x50G": ["Eth4/1", "Eth4/3"],
+                "4x25G[10G]": ["Eth4/1", "Eth4/2", "Eth4/3", "Eth4/4"]
+            }
         }
     }
 }