[fpmsyncd]: Route update frequency stats.

Changes:
 read threshold from config.
 write frequency of route update per sec in state db.

Signed-off-by: Praveen Chaudhary <[email protected]>
RB=
G=lnos-reviewers
R=pchaudhary,pmao,samaity,zxu
A=

Author: Praveen Chaudhary

fpmsyncd/routesync.cpp

@@ -12,6 +12,7 @@
 #include "macaddress.h"
 #include <string.h>
 #include <arpa/inet.h>
+#include <chrono>
 
 using namespace std;
 using namespace swss;
@@ -41,6 +42,13 @@ using namespace swss;
 
 #define ETHER_ADDR_STRLEN (3*ETH_ALEN)
 
+
+/* helper function for time */
+uint64_t getTimeEpochMsec() {
+  using namespace std::chrono;
+  return duration_cast<milliseconds>(system_clock::now().time_since_epoch()).count();
+}
+
 RouteSync::RouteSync(RedisPipeline *pipeline) :
     m_routeTable(pipeline, APP_ROUTE_TABLE_NAME, true),
     m_vnet_routeTable(pipeline, APP_VNET_RT_TABLE_NAME, true),
@@ -51,6 +59,34 @@ RouteSync::RouteSync(RedisPipeline *pipeline) :
     m_nl_sock = nl_socket_alloc();
     nl_connect(m_nl_sock, NETLINK_ROUTE);
     rtnl_link_alloc_cache(m_nl_sock, AF_UNSPEC, &m_link_cache);
+
+    /* Initailize with defaults*/
+    RED_THRESHOLD = 500;
+    ORANGE_THRESHOLD = 100;
+    countRedroute = 0;
+    countOrangeroute = 0;
+
+    /* update the time at start */
+    lastRedUpdated = getTimeEpochMsec();
+    lastOrangeUpdated = lastRedUpdated;
+
+    /* READ THESHOLD CONFIG from BGP_ROUTE_THRESHOLD Table*/
+    this->cfgDb = new DBConnector("CONFIG_DB", 0);
+    this->cfgRouteThTable = new Table(this->cfgDb, "BGP_ROUTE_THRESHOLD");
+
+    /* WRITE STATS in BGP_ROUTE_UPDATE_FREQUENCY Table STATE DB*/
+    this->stateDb = new DBConnector("STATE_DB", 0);
+    this->bgpRouteFreqTable = new Table(this->stateDb, "BGP_ROUTE_UPDATE_FREQUENCY");
+
+    /* Remove later */
+    SWSS_LOG_NOTICE("PC: fpmsyncd debug image");
+}
+
+RouteSync::~RouteSync() {
+    delete cfgRouteThTable;
+    delete bgpRouteFreqTable;
+    delete cfgDb;
+    delete stateDb;
 }
 
 char *RouteSync::prefixMac2Str(char *mac, char *buf, int size)
@@ -443,6 +479,8 @@ void RouteSync::onEvpnRouteMsg(struct nlmsghdr *h, int len)
 
     if (nlmsg_type == RTM_DELROUTE)
     {
+        /* update route change frequency */
+        updateRouteFrequencyStats();
         if (!warmRestartInProgress)
         {
             m_routeTable.del(destipprefix);
@@ -519,6 +557,8 @@ void RouteSync::onEvpnRouteMsg(struct nlmsghdr *h, int len)
     fvVector.push_back(intf);
     fvVector.push_back(vni);
     fvVector.push_back(mac);
+   /* update route change frequency */
+    updateRouteFrequencyStats();
 
     if (!warmRestartInProgress)
     {
@@ -643,6 +683,8 @@ void RouteSync::onRouteMsg(int nlmsg_type, struct nl_object *obj, char *vrf)
 
     if (nlmsg_type == RTM_DELROUTE)
     {
+         /* update route change frequency */
+        updateRouteFrequencyStats();
         if (!warmRestartInProgress)
         {
             m_routeTable.del(destipprefix);
@@ -723,6 +765,9 @@ void RouteSync::onRouteMsg(int nlmsg_type, struct nl_object *obj, char *vrf)
     fvVector.push_back(nh);
     fvVector.push_back(idx);
 
+   /* update route change frequency */
+    updateRouteFrequencyStats();
+
     if (!warmRestartInProgress)
     {
         m_routeTable.set(destipprefix, fvVector);
@@ -775,6 +820,9 @@ void RouteSync::onVnetRouteMsg(int nlmsg_type, struct nl_object *obj, string vne
 
     if (nlmsg_type == RTM_DELROUTE)
     {
+        /* update route change frequency */
+        updateRouteFrequencyStats();
+
         /* Duplicated delete as we do not know if it is a VXLAN tunnel route*/
         m_vnet_routeTable.del(vnet_dip);
         m_vnet_tunnelTable.del(vnet_dip);
@@ -813,6 +861,9 @@ void RouteSync::onVnetRouteMsg(int nlmsg_type, struct nl_object *obj, string vne
         return;
     }
 
+   /* update route change frequency */
+    updateRouteFrequencyStats();
+
     /* Get nexthop lists */
     string nexthops = getNextHopGw(route_obj);
     string ifnames = getNextHopIf(route_obj);
@@ -962,3 +1013,40 @@ string RouteSync::getNextHopIf(struct rtnl_route *route_obj)
 
     return result;
 }
+
+void RouteSync::updateRouteFrequencyStats() {
+
+    ++countRedroute;
+    ++countOrangeroute;
+
+    /* Read Config DB for Threshold Value */
+    string value;
+    string CONFIG_KEY = "ROUTE_UPDATE_THRESHOLD";
+    bool ret = cfgRouteThTable->hget(CONFIG_KEY, "RED_THRESHOLD", value);
+    if (ret)
+        RED_THRESHOLD = (u_int16_t)std::stoi(value);
+    ret = cfgRouteThTable->hget(CONFIG_KEY, "ORANGE_THRESHOLD", value);
+    if (ret)
+        ORANGE_THRESHOLD = (u_int16_t)std::stoi(value);
+
+
+    string STATE_DB_KEY = "ROUTE_UPDATE_FREQUENCY";
+    if (countRedroute >= RED_THRESHOLD) {
+        uint64_t curTime = getTimeEpochMsec();
+        double timeDiff = (double)(curTime-lastRedUpdated)/1000.00;
+        /*TODO: change log level*/
+        SWSS_LOG_NOTICE("Red TH: %d routes are updated in %.3f secs\n", countRedroute, timeDiff);
+        bgpRouteFreqTable->hset(STATE_DB_KEY, "RED_THRESHOLD", std::to_string(countRedroute/timeDiff));
+        lastRedUpdated = curTime;
+        countRedroute = 0;
+    }
+
+    if (countOrangeroute >= ORANGE_THRESHOLD) {
+        uint64_t curTime = getTimeEpochMsec();
+        double timeDiff = (double)(curTime-lastOrangeUpdated)/1000.00;
+        SWSS_LOG_NOTICE("Orange TH: %d routes are updated in %.3f secs\n", countOrangeroute, timeDiff);
+        bgpRouteFreqTable->hset(STATE_DB_KEY, "ORANGE_THRESHOLD", std::to_string(countOrangeroute/timeDiff));
+        lastOrangeUpdated = curTime;
+        countOrangeroute = 0;
+    }
+}

fpmsyncd/routesync.h

@@ -22,6 +22,7 @@ class RouteSync : public NetMsg
     enum { MAX_ADDR_SIZE = 64 };
 
     RouteSync(RedisPipeline *pipeline);
+    virtual ~RouteSync();
 
     virtual void onMsg(int nlmsg_type, struct nl_object *obj);
 
@@ -75,6 +76,29 @@ class RouteSync : public NetMsg
 
     /* Get next hop interfaces */
     string getNextHopIf(struct rtnl_route *route_obj);
+
+    void updateRouteFrequencyStats();
+
+    /* User Configured Threshold */
+    uint16_t RED_THRESHOLD;
+    uint16_t ORANGE_THRESHOLD;
+
+    /* Current route updates count */
+    uint16_t countRedroute;
+    uint16_t countOrangeroute;
+
+    /* timestamp for last frequency update */
+    uint64_t lastRedUpdated;
+    uint64_t lastOrangeUpdated;
+
+    /* Read Config from below Table in CONFIG_DB*/
+    DBConnector *cfgDb;
+    Table *cfgRouteThTable;
+
+    /* Write Frequency updates to below Table in STATE_DB*/
+    DBConnector *stateDb;
+    Table *bgpRouteFreqTable;
+
 };
 
 }