cleanup tests, lint

Author: jonkeane

internal/interpreters/r_test.go

@@ -788,48 +788,19 @@ func (s *CreateLockfileFunctionalSuite) TearDownSuite() {
 // TestCreateLockfileWithSpacesInPath tests that CreateLockfile can successfully
 // create a lockfile in a path that contains spaces
 func (s *CreateLockfileFunctionalSuite) TestCreateLockfileWithSpacesInPath() {
-	// Skip if R is not available with renv
-	// if !s.isRenvAvailable() {
-	// 	s.T().Skip("renv package is not available in R")
-	// 	return
-	// }
-
-	// Create a lockfile path with spaces
+	// Create a lockfile on a path with spaces, this is problematic on Windows but
 	lockfilePath := util.NewAbsolutePath(filepath.Join(s.tempSpaceDir, "renv.lock"), s.fs)
 
 	// Ensure the directory exists
 	err := os.MkdirAll(filepath.Dir(lockfilePath.String()), 0755)
 	s.Require().NoError(err)
 
-	// Try to create the lockfile
+	// Try to successfully create the lockfile
 	err = s.rInterpreter.CreateLockfile(lockfilePath)
-
-	// This should succeed with our fix
 	s.NoError(err, "CreateLockfile should succeed with spaces in the path")
 
-	// Verify the lockfile was created
+	// And verify
 	exists, err := lockfilePath.Exists()
 	s.NoError(err, "Should be able to check if lockfile exists")
 	s.True(exists, "Lockfile should exist after CreateLockfile")
 }
-
-// isRenvAvailable checks if the renv package is available in R
-func (s *CreateLockfileFunctionalSuite) isRenvAvailable() bool {
-	// We'll assume renv might be available if:
-	// 1. R is available (we already checked this)
-	// 2. We have a valid R interpreter
-
-	// First, let's just create a minimal test file without spaces
-	tempLockfile := util.NewAbsolutePath(filepath.Join(s.tempDir, "test.lock"), s.fs)
-
-	// Try to create it - this will fail if renv isn't available
-	err := s.rInterpreter.CreateLockfile(tempLockfile)
-	if err != nil {
-		fmt.Printf("Error creating test lockfile: %v\n", err)
-		return false
-	}
-
-	// If we got here, renv is probably available
-	exists, _ := tempLockfile.Exists()
-	return exists
-}