Skip to content

Some images not loading #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Sleni82 opened this issue Jan 30, 2021 · 10 comments · Fixed by #529
Closed

Some images not loading #527

Sleni82 opened this issue Jan 30, 2021 · 10 comments · Fixed by #529
Assignees
@pomle
Labels
bug Something isn't working

Comments

@Sleni82
Copy link
Collaborator

Sleni82 commented Jan 30, 2021

It seems that some images from articles are not loading.

Se attached screenshots
Screenshot_20210130-164605_Chrome
Screenshot_20210130-164549_Chrome
@Sleni82 Sleni82 added the bug Something isn't working label Jan 30, 2021
@pomle
Copy link
Owner

pomle commented Jan 30, 2021

That's pretty fucked up. Looked in the logs and it does not say anything. Stupid cloud functions. :)

@Sleni82
Copy link
Collaborator Author

Sleni82 commented Jan 30, 2021

Yeah, i saw it both in Daniel Andersson collection and on your check in for bergslagen

@pomle
Copy link
Owner

pomle commented Jan 30, 2021

I am seeing this error in logs.
googleapis/google-cloud-node#654

@pomle
Copy link
Owner

pomle commented Jan 30, 2021

We do a little trick when user uploads images and write a small image immediately that the user sees, then upload the original so the user does not have to wait for the full size to upload.

I think we start processing the image before it is fully uploaded and that is why the checksum is not failed. Will think about how to fix in a good way.

@pomle
Copy link
Owner

pomle commented Jan 30, 2021

Updated the Cloud Function that creates images to allow for lazy setting of source
3a8ec63

@Sleni82
Copy link
Collaborator Author

Sleni82 commented Jan 30, 2021

Will test!

@pomle
Copy link
Owner

pomle commented Jan 30, 2021

Why?

@Sleni82
Copy link
Collaborator Author

Sleni82 commented Jan 30, 2021

Dont know

@pomle
Copy link
Owner

pomle commented Jan 30, 2021

This should improve uploading robustness somewhat.
#529

@pomle pomle linked a pull request Jan 30, 2021 that will close this issue
Tweak image uploading #529
Merged
@pomle
Copy link
Owner

pomle commented Jan 30, 2021

@Sleni82 now you can test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomle pomle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweak image uploading pomle/corkheads
2 participants
@pomle @Sleni82