Skip to content

Commit 4c11dac

Browse files
committed
feat: add comments in tests
1 parent 3409c38 commit 4c11dac

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

ts-tests/tests/test-pending-pool.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ describeWithFrontierAllPools("Frontier RPC (Pending Pool)", (context) => {
88
const TEST_CONTRACT_BYTECODE =
99
"0x6080604052348015600f57600080fd5b5060ae8061001e6000396000f3fe6080604052348015600f57600080fd5b506004361060285760003560e01c8063c6888fa114602d575b600080fd5b605660048036036020811015604157600080fd5b8101908080359060200190929190505050606c565b6040518082815260200191505060405180910390f35b600060078202905091905056fea265627a7a72315820f06085b229f27f9ad48b2ff3dd9714350c1698a37853a30136fa6c5a7762af7364736f6c63430005110032";
1010

11+
// This is needed due to behaviour of fatp in manual seal conensus
12+
// Before the first block is created, the pool will wrongly report as empty
13+
// https://github.com/paritytech/polkadot-sdk/issues/8402
1114
before("create and finalize block 1", async function () {
1215
await createAndFinalizeBlock(context.web3);
1316
});
@@ -52,6 +55,9 @@ describeWithFrontierAllPools("Frontier RPC (Pending Pool)", (context) => {
5255
describeWithFrontierAllPools("Frontier RPC (Pending Transaction Count)", (context) => {
5356
const TEST_ACCOUNT = "0x1111111111111111111111111111111111111111";
5457

58+
// This is needed due to behaviour of fatp in manual seal conensus
59+
// Before the first block is created, the pool will wrongly report as empty
60+
// https://github.com/paritytech/polkadot-sdk/issues/8402
5561
before("create and finalize block 1", async function () {
5662
await createAndFinalizeBlock(context.web3);
5763
});

ts-tests/tests/txpool.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ describeWithFrontierAllPools("Frontier RPC (TxPoolApi)", (context) => {
2727
return tx;
2828
}
2929

30+
// This is needed due to behaviour of fatp in manual seal conensus
31+
// Before the first block is created, the pool will wrongly report as empty
32+
// https://github.com/paritytech/polkadot-sdk/issues/8402
3033
before("create and finalize a block 1", async function () {
3134
await createAndFinalizeBlock(context.web3);
3235
});

0 commit comments

Comments
 (0)