Skip to content

Commit f3cbd01

Browse files
authored
test: add jest-dom matchers and eslint plugin (#997)
1 parent e65fd89 commit f3cbd01

File tree

8 files changed

+91
-5
lines changed

8 files changed

+91
-5
lines changed

.eslintrc.json

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
"react-hooks",
2222
"import",
2323
"@vitest",
24+
"jest-dom",
2425
"testing-library",
2526
"eslint-plugin-react-compiler"
2627
],
@@ -107,6 +108,7 @@
107108
"overrides": [
108109
{
109110
"extends": [
111+
"plugin:jest-dom/recommended",
110112
"plugin:testing-library/react",
111113
"plugin:@vitest/legacy-recommended"
112114
],

.github/workflows/test-old-typescript.yml

-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ jobs:
4141
if: ${{ startsWith(matrix.typescript, '4.') || startsWith(matrix.typescript, '3.') }}
4242
run: |
4343
sed -i~ 's/"verbatimModuleSyntax": true,//' tsconfig.json
44-
sed -i~ 's/"lib": \["es2023"\],//' tsconfig.json
4544
- name: Patch for Old TS
4645
run: |
4746
sed -i~ 's/"moduleResolution": "bundler",/"moduleResolution": "node",/' tsconfig.json

package.json

+2
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@
111111
"@rollup/plugin-node-resolve": "^15.3.0",
112112
"@rollup/plugin-replace": "^6.0.1",
113113
"@rollup/plugin-typescript": "^12.1.1",
114+
"@testing-library/jest-dom": "^6.6.3",
114115
"@testing-library/react": "^16.0.1",
115116
"@types/jsdom": "^21.1.7",
116117
"@types/react": "^18.3.12",
@@ -125,6 +126,7 @@
125126
"eslint-config-prettier": "^9.1.0",
126127
"eslint-import-resolver-alias": "^1.1.2",
127128
"eslint-plugin-import": "^2.31.0",
129+
"eslint-plugin-jest-dom": "^5.4.0",
128130
"eslint-plugin-prettier": "^5.2.1",
129131
"eslint-plugin-react": "^7.37.2",
130132
"eslint-plugin-react-compiler": "19.0.0-beta-8a03594-20241020",

pnpm-lock.yaml

+80
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/proxySet.test.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -649,7 +649,7 @@ describe('ui updates - useSnapshot', async () => {
649649

650650
fireEvent.click(screen.getByText('Add Item'))
651651

652-
expect(await screen.findByText('1')).toBeDefined()
652+
expect(await screen.findByText('1')).toBeInTheDocument()
653653
})
654654

655655
it('should be reactive to changes when using keys method', async () => {
@@ -682,7 +682,7 @@ describe('ui updates - useSnapshot', async () => {
682682
)
683683

684684
fireEvent.click(screen.getByText('Add Item'))
685-
expect(await screen.findByText('item key: 1')).toBeDefined()
685+
expect(await screen.findByText('item key: 1')).toBeInTheDocument()
686686
})
687687

688688
it('should be reactive to changes when using entries method', async () => {
@@ -715,7 +715,7 @@ describe('ui updates - useSnapshot', async () => {
715715
)
716716

717717
fireEvent.click(screen.getByText('Add Item'))
718-
expect(await screen.findByText('key: 1; value: 1')).toBeDefined()
718+
expect(await screen.findByText('key: 1; value: 1')).toBeInTheDocument()
719719
})
720720
})
721721

tests/setup.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import '@testing-library/jest-dom/vitest'

tsconfig.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"compilerOptions": {
33
"target": "esnext",
44
"strict": true,
5-
"lib": ["es2023"],
5+
"lib": ["dom"],
66
"jsx": "react-jsx",
77
"esModuleInterop": true,
88
"module": "esnext",
@@ -14,6 +14,7 @@
1414
"verbatimModuleSyntax": true,
1515
"declaration": true,
1616
"isolatedDeclarations": true,
17+
"types": ["@testing-library/jest-dom"],
1718
"noEmit": true,
1819
"baseUrl": ".",
1920
"paths": {

vitest.config.ts

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export default defineConfig({
1414
// Keeping globals to true triggers React Testing Library's auto cleanup
1515
// https://vitest.dev/guide/migration.html
1616
globals: true,
17+
setupFiles: ['tests/setup.ts'],
1718
coverage: {
1819
include: ['src/**/'],
1920
reporter: ['text', 'json', 'html', 'text-summary'],

0 commit comments

Comments
 (0)