Skip to content

[JOSS] ambiguous data path in paper example #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
platipodium opened this issue Jun 6, 2023 · 2 comments
Closed

[JOSS] ambiguous data path in paper example #65

platipodium opened this issue Jun 6, 2023 · 2 comments

Comments

@platipodium
Copy link

In the JOSS paper, you write

ds_clim = nc.open_data("sst.mon.mean.nc")
ds_present = nc.open_data("data/sst.mon.mean.nc")

This is misleading. Are both datasets the same file? Why in different folders?

See openjournals/joss-reviews#5494

@platipodium
Copy link
Author

... and while you're at it, the title command exceeds the line length, so you could introduce a line break :=)

@robertjwilson
Copy link
Member

Path is now fixed along with line break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants