Skip to content

[JOSS] Missing declaration of optional dependency on cartopy #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
platipodium opened this issue May 27, 2023 · 1 comment
Closed

[JOSS] Missing declaration of optional dependency on cartopy #60

platipodium opened this issue May 27, 2023 · 1 comment

Comments

@platipodium
Copy link

Neither conda nor pip install cartopy as a dependency. This leads to garbled plots on my machine, but you do provide a helpful message

Unable to import cartopy. For better plots install cartopy or check cartopy installation!

Maybe this should be documented.

openjournals/joss-reviews#5494

@platipodium platipodium changed the title Missing declaration of optional dependency on carroty [JOSS] Missing declaration of optional dependency on cartopy Jun 6, 2023
@robertjwilson
Copy link
Member

Was the garbled plotting not due to an issue with a major update to the panel package and not cartopy?

The installation docs explained the cartopy issue, but very well. I've just added a "How to get better plots" section to installation. https://nctoolkit.readthedocs.io/en/latest/installing.html

That should clarify things for users do a new install. Ideally cartopy would be an explicit dependency on conda, but having it slows the installation down enormously. If everyone used mamba I could switch it.

I've closed the issue, as this is hopefully now fully clear in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants