Skip to content

Commit 1788b5f

Browse files
pm-kapil-tuptewarpm-kapil-tuptewar
authored
Merge pull request #6 from kapil-tuptewar/UOE-9819
Uoe 9819
2 parents c354f86 + 958043a commit 1788b5f

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

‎modules/pubmaticAnalyticsAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {_each, isArray, isStr, logError, logWarn, pick} from '../src/utils.js';
1+
import {_each, isArray, isStr, logError, logWarn, pick, generateUUID} from '../src/utils.js';
22
import adapter from '../libraries/analyticsAdapter/AnalyticsAdapter.js';
33
import adapterManager from '../src/adapterManager.js';
44
import CONSTANTS from '../src/constants.json';
@@ -379,6 +379,7 @@ function executeBidsLoggerCall(e, highestCpmBids) {
379379
'sz': getSizesForAdUnit(adUnit, adUnitId),
380380
'ps': gatherPartnerBidsForAdUnitForLogger(adUnit, adUnitId, highestCpmBids.filter(bid => bid.adUnitCode === adUnitId)),
381381
'fskp': floorData && floorFetchStatus ? (floorData.floorRequestData ? (floorData.floorRequestData.skipped == false ? 0 : 1) : undefined) : undefined,
382+
'sid': generateUUID()
382383
};
383384
if (floorData?.floorRequestData) {
384385
const { location, fetchStatus, floorProvider } = floorData?.floorRequestData;

‎test/spec/modules/pubmaticAnalyticsAdapter_spec.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -374,6 +374,7 @@ describe('pubmatic analytics adapter', function () {
374374
// slot 1
375375
expect(data.s[0].sn).to.equal('/19968336/header-bid-tag-0');
376376
expect(data.s[0].fskp).to.equal(0);
377+
expect(data.s[0].sid).not.to.be.undefined;
377378
expect(data.s[0].ffs).to.equal(1);
378379
expect(data.s[0].fsrc).to.equal(2);
379380
expect(data.s[0].fp).to.equal('pubmatic');
@@ -406,6 +407,7 @@ describe('pubmatic analytics adapter', function () {
406407
// slot 2
407408
expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1');
408409
expect(data.s[1].fskp).to.equal(0);
410+
expect(data.s[1].sid).not.to.be.undefined;
409411
expect(data.s[1].ffs).to.equal(1);
410412
expect(data.s[1].fsrc).to.equal(2);
411413
expect(data.s[1].fp).to.equal('pubmatic');
@@ -589,6 +591,7 @@ describe('pubmatic analytics adapter', function () {
589591
// slot 1
590592
expect(data.s[0].sn).to.equal('/19968336/header-bid-tag-0');
591593
expect(data.s[0].fskp).to.equal(0);
594+
expect(data.s[0].sid).not.to.be.undefined;
592595
expect(data.s[0].ffs).to.equal(1);
593596
expect(data.s[0].fsrc).to.equal(2);
594597
expect(data.s[0].fp).to.equal('pubmatic');
@@ -711,9 +714,13 @@ describe('pubmatic analytics adapter', function () {
711714
expect(data.tgid).to.equal(0);// test group id should be an INT between 0-15 else set to 0
712715
expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1');
713716
expect(data.s[1].fskp).to.equal(0);
717+
718+
expect(data.s[1].sid).not.to.be.undefined;
719+
714720
expect(data.s[1].ffs).to.equal(1);
715721
expect(data.s[1].fsrc).to.equal(2);
716722
expect(data.s[1].fp).to.equal('pubmatic');
723+
717724
expect(data.s[1].sz).to.deep.equal(['1000x300', '970x250', '728x90']);
718725
expect(data.s[1].ps).to.be.an('array');
719726
expect(data.s[1].ps.length).to.equal(1);
@@ -796,6 +803,7 @@ describe('pubmatic analytics adapter', function () {
796803
let data = getLoggerJsonFromRequest(request.requestBody);
797804
expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1');
798805
expect(data.s[1].fskp).to.equal(0);
806+
expect(data.s[1].sid).not.to.be.undefined;
799807
expect(data.s[1].ffs).to.equal(1);
800808
expect(data.s[1].fsrc).to.equal(2);
801809
expect(data.s[1].fp).to.equal('pubmatic');
@@ -861,6 +869,7 @@ describe('pubmatic analytics adapter', function () {
861869
expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1');
862870
expect(data.s[1].sz).to.deep.equal(['1000x300', '970x250', '728x90']);
863871
expect(data.s[1].ps).to.be.an('array');
872+
expect(data.s[1].sid).not.to.be.undefined;
864873
expect(data.s[1].ps.length).to.equal(1);
865874
expect(data.s[1].ps[0].pn).to.equal('pubmatic');
866875
expect(data.s[1].ps[0].bc).to.equal('pubmatic');
@@ -908,6 +917,7 @@ describe('pubmatic analytics adapter', function () {
908917
let data = getLoggerJsonFromRequest(request.requestBody);
909918
expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1');
910919
expect(data.s[1].fskp).to.equal(0);
920+
expect(data.s[1].sid).not.to.be.undefined;
911921
expect(data.s[1].ffs).to.equal(1);
912922
expect(data.s[1].fsrc).to.equal(2);
913923
expect(data.s[1].fp).to.equal('pubmatic');
@@ -970,6 +980,7 @@ describe('pubmatic analytics adapter', function () {
970980
let data = getLoggerJsonFromRequest(request.requestBody);
971981
expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1');
972982
expect(data.s[1].sz).to.deep.equal(['1000x300', '970x250', '728x90']);
983+
expect(data.s[1].sid).not.to.be.undefined;
973984
expect(data.s[1].ps).to.be.an('array');
974985
expect(data.s[1].ps.length).to.equal(1);
975986
expect(data.s[1].ps[0].pn).to.equal('pubmatic');
@@ -1024,6 +1035,7 @@ describe('pubmatic analytics adapter', function () {
10241035
let data = getLoggerJsonFromRequest(request.requestBody);
10251036
expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1');
10261037
expect(data.s[1].fskp).to.equal(0);
1038+
expect(data.s[1].sid).not.to.be.undefined;
10271039
expect(data.s[1].ffs).to.equal(1);
10281040
expect(data.s[1].fsrc).to.equal(2);
10291041
expect(data.s[1].fp).to.equal('pubmatic');
@@ -1084,6 +1096,7 @@ describe('pubmatic analytics adapter', function () {
10841096
let data = getLoggerJsonFromRequest(request.requestBody);
10851097
expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1');
10861098
expect(data.s[1].sz).to.deep.equal(['1000x300', '970x250', '728x90']);
1099+
expect(data.s[1].sid).not.to.be.undefined;
10871100
expect(data.s[1].ps).to.be.an('array');
10881101
expect(data.s[1].ps.length).to.equal(1);
10891102
expect(data.s[1].ps[0].pn).to.equal('pubmatic');
@@ -1146,6 +1159,7 @@ describe('pubmatic analytics adapter', function () {
11461159
expect(data.s[1].fsrc).to.equal(2);
11471160
expect(data.s[1].fp).to.equal('pubmatic');
11481161
expect(data.s[1].sz).to.deep.equal(['1000x300', '970x250', '728x90']);
1162+
expect(data.s[1].sid).not.to.be.undefined;
11491163
expect(data.s[1].ps).to.be.an('array');
11501164
expect(data.s[1].ps.length).to.equal(1);
11511165
expect(data.s[1].ps[0].pn).to.equal('pubmatic');
@@ -1224,6 +1238,7 @@ describe('pubmatic analytics adapter', function () {
12241238
expect(data.s[0].fsrc).to.equal(2);
12251239
expect(data.s[0].fp).to.equal('pubmatic');
12261240
expect(data.s[0].sz).to.deep.equal(['640x480']);
1241+
expect(data.s[0].sid).not.to.be.undefined;
12271242
expect(data.s[0].ps).to.be.an('array');
12281243
expect(data.s[0].au).to.equal('/19968336/header-bid-tag-0');
12291244
expect(data.s[0].ps.length).to.equal(1);
@@ -1257,6 +1272,7 @@ describe('pubmatic analytics adapter', function () {
12571272
expect(data.s[1].fsrc).to.equal(2);
12581273
expect(data.s[1].fp).to.equal('pubmatic');
12591274
expect(data.s[1].sz).to.deep.equal(['1000x300', '970x250', '728x90']);
1275+
expect(data.s[1].sid).not.to.be.undefined;
12601276
expect(data.s[1].ps).to.be.an('array');
12611277
expect(data.s[1].ps.length).to.equal(1);
12621278
expect(data.s[1].ps[0].pn).to.equal('pubmatic');
@@ -1352,6 +1368,7 @@ describe('pubmatic analytics adapter', function () {
13521368
expect(data.s[0].fsrc).to.equal(2);
13531369
expect(data.s[0].fp).to.equal('pubmatic');
13541370
expect(data.s[0].sz).to.deep.equal(['640x480']);
1371+
expect(data.s[0].sid).not.to.be.undefined;
13551372
expect(data.s[0].ps).to.be.an('array');
13561373
expect(data.s[0].au).to.equal('/19968336/header-bid-tag-0');
13571374
expect(data.s[0].ps.length).to.equal(1);
@@ -1381,6 +1398,7 @@ describe('pubmatic analytics adapter', function () {
13811398
// slot 2
13821399
expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1');
13831400
expect(data.s[1].sz).to.deep.equal(['1000x300', '970x250', '728x90']);
1401+
expect(data.s[1].sid).not.to.be.undefined;
13841402
expect(data.s[1].ps).to.be.an('array');
13851403
expect(data.s[1].ps.length).to.equal(1);
13861404
expect(data.s[1].ps[0].pn).to.equal('pubmatic');

0 commit comments

Comments
 (0)