Skip to content

Release v0.2.13 raises MSRV without raising minor version #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asomers opened this issue May 5, 2020 · 1 comment
Closed

Release v0.2.13 raises MSRV without raising minor version #140

asomers opened this issue May 5, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@asomers
Copy link

asomers commented May 5, 2020

plotters release v0.2.12 was compilable with Rust 1.36.0, and probably older versions too. But version v0.2.13 requires Rust 1.40.0. That means that downstream crates are suddenly breaking from cargo update. Raising the MSRV should be considered a backwards-incompatible change, because it can break your consumers' builds.

Please commit to maintaining a stable MSRV in the future. You can easily verify it in CI.

See https://users.rust-lang.org/t/rust-version-requirement-change-as-semver-breaking-or-not/20980/30 for discussion.

@asomers asomers added the bug Something isn't working label May 5, 2020
@38
Copy link
Member

38 commented May 5, 2020

Oops, thanks for reporting this. Believe this is fixed with latest release 0.2.14.
Really appreciated about the advice.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants