Sync version degraded

[ayjayt]

The sync version of choreographer is degrading due to code duplication, will expound later.

[gvwilson]

@ayjayt does this need to be addressed for the March 2025 release or nah? cc @emilykl

[ayjayt]

@gvwilson, @emilykl

This will not impact kaleido.

I'm thinking of removing the synchronous branches from choreographer (we don't use them) because they degrade as the async branches are updated. It would technically be an API change, I have to think about it a bit, but probably make a decision this month.

Technical Explanation:

Writing syncronous and async/await frameworks in parallel is made difficult because functions that basically do the same thing have to be written twice because language keywords (and internal behavior) are slightly different. On a high level, async and sync functions can't be mixed, but on a very low level (where choreographer is), async functions are just wrapped sync functions, and it would be convenient if they could be mixed. But its a very tall order, and unlike javascript, the python community is not completely dedicated to async/await. Forcing users to use it seems somewhat daring. Our solution w/ kaleido is pretty good where it handles its async/await in a separate thread if you want to imitate sync, but would be a bigger pill to swallow if you meant kaleido as a purely synchronous layer.

[ayjayt]

Diagnose is now skipping sync tests