fix minecraft hiding via --noconsole

Author: Simeon Kummer

.github/workflows/pythonbuild.yml

@@ -27,7 +27,7 @@ jobs:
         run: pip install minecraft-launcher-lib==7.1
 
       - name: Build executable with PyInstaller
-        run: pyinstaller -y --onefile --name os launch.py
+        run: pyinstaller -y --onefile --name os launch.py --noconsole
 
       - name: Upload executable
         uses: actions/upload-artifact@v4

src/minecraftStarter.js

@@ -334,13 +334,7 @@ class MinecraftStarter {
         detached: true
       };
 
-      // On Windows, prevent cmd window from showing without hiding Minecraft
-      if (process.platform === 'win32') {
-        spawnOptions.shell = false; // Don't use shell, prevents cmd window
-        spawnOptions.stdio = ['ignore', 'ignore', 'ignore']; // Suppress stdio but allow windows
-      } else {
-        spawnOptions.stdio = 'inherit';
-      }
+      spawnOptions.stdio = 'inherit';
 
       // Spawn the process
       const process = spawn(args[0], args.slice(1), spawnOptions);