Skip to content

Allow users to specify indexes for Page and User Custom Variables #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcsorba opened this issue Jan 3, 2016 · 3 comments
Closed
Assignees

Comments

@bcsorba
Copy link
Collaborator

bcsorba commented Jan 3, 2016

Users are currently able to only add custom variables and as such are unable to specify an index for a custom variable. This prevents users from actively setting the index of their custom variables and makes it impossible for users to send a custom variable at a given index unless they've specified custom variables for all indexes before that given index.

Plan to deprecate the current getters and setters for page a user custom variables and allow users to get and set a new CustomVariable object at a specified index.

@bcsorba bcsorba self-assigned this Jan 3, 2016
@mattab
Copy link
Member

mattab commented Aug 22, 2016

Nice to solve this one @bcsorba - keep up the great work 👍

@bcsorba
Copy link
Collaborator Author

bcsorba commented Aug 23, 2016

Thanks @mattab! Released in 1.2

@liammkelly
Copy link

Thanks Brett! I'm in business now.

Liam

On Mon, Aug 22, 2016 at 1:25 AM, Brett Csorba [email protected]
wrote:

Closed #11 #11 via
fb8e60e
fb8e60e
.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAsYEpLH-4EbViosDSm5HBgG_HNy2LW1ks5qiTLXgaJpZM4G9qSg
.

Sent from my iPhone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants