Skip to content

Stand up integration tests for S3 and GCS #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JPZ13 opened this issue Mar 27, 2023 · 2 comments
Open

Stand up integration tests for S3 and GCS #18

JPZ13 opened this issue Mar 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@JPZ13
Copy link
Collaborator

JPZ13 commented Mar 27, 2023

This ticket is two parts:

  1. Standing up an S3 and GCS bucket in Pipekit infrastructure for testing
  2. Adding integration tests to the Argo Workflows codebase that validate that reads/writes to S3 and GCS work as intended

We'll need @tico24 to stand up the infrastructure, provision any secrets needed, and add them to the appropriate secrets store (most likely the Github secrets on this repo)

From there, we're free to implement the tests that do the connection however we see fit. I know @Joibel and @tico24 have both mentioned that they would like to test workflows using Argo Workflows itself. I'll leave that decision on whether to do that in this PR to y'all

@JPZ13 JPZ13 added the enhancement New feature or request label Mar 27, 2023
@tico24
Copy link
Collaborator

tico24 commented Mar 27, 2023

Oddly, I have a PR to add s3 buckets to our internal workflows instance already, so this is almost 'done'.

For GCS, I'll need... GCS please @JPZ13

@tico24
Copy link
Collaborator

tico24 commented Mar 27, 2023

s3 is now set up internally.

@Joibel will need various bits of internal access in order to use it though. Probably not sensible to document on this public repo.

@tico24 tico24 unassigned Joibel and tico24 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants