Skip to content

Remove a temp sshkey file when terminating Piped #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pipecd-bot opened this issue Jul 12, 2021 · 1 comment · Fixed by #5769
Closed

Remove a temp sshkey file when terminating Piped #2215

pipecd-bot opened this issue Jul 12, 2021 · 1 comment · Fixed by #5769
Assignees
@hiep-tk
Labels
area/piped good first issue Good education for newcomers kind/todo

Comments

@pipecd-bot
Copy link
Collaborator

https://github.com/pipe-cd/pipe/blob/3ab99b8cf5056061a90f5e4759b4f46eb38c5184/pkg/git/ssh_config.go#L76-L79

This was created by todo plugin since "TODO:" was found in 3ab99b8 when #2214 was merged. cc: @nghialv.
@funera1 funera1 self-assigned this Feb 17, 2023
@khanhtc1202 khanhtc1202 added the good first issue Good education for newcomers label Apr 14, 2023
@t-kikuc t-kikuc changed the title Remove this key file when Piped terminating. Remove a temp sshkey file when terminating Piped Oct 4, 2024
hiep-tk added a commit to hiep-tk/pipecd that referenced this issue Apr 22, 2025
@hiep-tk
remove temp sshKeyFile after use(pipe-cd#2215)
db1f45e 
Signed-off-by: hiep-tk <[email protected]>
hiep-tk added a commit to hiep-tk/pipecd that referenced this issue Apr 22, 2025
@hiep-tk
remove temp sshKeyFile after use(pipe-cd#2215)
68fe2c7 
Signed-off-by: hiep-tk <[email protected]>
hiep-tk added a commit to hiep-tk/pipecd that referenced this issue Apr 22, 2025
@hiep-tk
remove temp sshKeyFile after use(pipe-cd#2215)
9c3273e 
Signed-off-by: hiep-tk <[email protected]>
hiep-tk added a commit to hiep-tk/pipecd that referenced this issue Apr 22, 2025
@hiep-tk
remove temp sshKeyFile after use(pipe-cd#2215)
66eaf29 
Signed-off-by: hiep-tk <[email protected]>
hiep-tk added a commit to hiep-tk/pipecd that referenced this issue Apr 22, 2025
@hiep-tk
remove temp sshKeyFile after use(pipe-cd#2215)
4238799 
Signed-off-by: hiep-tk <[email protected]>
hiep-tk added a commit to hiep-tk/pipecd that referenced this issue Apr 22, 2025
@hiep-tk
remove temp sshKeyFile after use(pipe-cd#2215)
db532f3 
Signed-off-by: hiep-tk <[email protected]>
khanhtc1202 pushed a commit that referenced this issue Apr 22, 2025
@hiep-tk
remove temp sshKeyFile after use(#2215) (#5769)
bbc6ea5 
Signed-off-by: hiep-tk <[email protected]>
@t-kikuc
Copy link
Member

t-kikuc commented Apr 22, 2025 •
edited
Loading

Solved by #2215 #5769

@t-kikuc t-kikuc closed this as completed Apr 22, 2025
@hiep-tk hiep-tk mentioned this issue Apr 22, 2025
Merged
@Warashi Warashi added this to v0.51.3 Apr 22, 2025
@Warashi Warashi moved this to Done in v0.51.3 Apr 22, 2025
github-actions bot pushed a commit that referenced this issue Apr 22, 2025
@hiep-tk @pipecd-bot
remove temp sshKeyFile after use(#2215) (#5769)
fbb0dc3 
Signed-off-by: hiep-tk <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Warashi added a commit that referenced this issue Apr 22, 2025
@github-actions @Warashi @hiep-tk
Cherry-pick to release-v0.51.x (#5772)
88a7414 
* Do treeless clone for git clone to improve performance (#5722)

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>

* remove temp sshKeyFile after use(#2215) (#5769)

Signed-off-by: hiep-tk <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>

---------

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: hiep-tk <[email protected]>
Co-authored-by: Shinnosuke Sawada-Dazai <[email protected]>
Co-authored-by: Hiep Trinh <[email protected]>
@github-actions github-actions bot mentioned this issue May 15, 2025
Merged
@github-actions github-actions bot mentioned this issue May 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hiep-tk hiep-tk

Labels
area/piped good first issue Good education for newcomers kind/todo
Projects
No open projects
v0.51.3
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove temp sshKeyFile after use hiep-tk/pipecd
6 participants
@nghialv @khanhtc1202 @funera1 @pipecd-bot @t-kikuc @hiep-tk