-
Notifications
You must be signed in to change notification settings - Fork 183
specifying Helm version doesn't seem to be used in plan-preview #5635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We have to pass the helm command path with the pipecd/pkg/app/piped/platformprovider/kubernetes/kustomize.go Lines 40 to 67 in 11bb23c
|
@JohnTitor pipecd/pkg/app/piped/platformprovider/kubernetes/loader.go Lines 209 to 218 in 11bb23c
|
Sure, let me take a look! |
What happened:
plan-preview currently fails if we use config/templates described in the "How to reproduce it" section.
The error itself is:
This is caused by older Helm, like v3.8.0. Helm v3.17.0, for instance, treats it without any failure.
The mysterious part of this problem is it still occurs even if we have a config like
helmVersion: 3.17.0
in pipecd.yaml. We thought it was used in plan-preview.I thought #4382 fixed the problem but for some reason our plan preview is still broken. Maybe we've misconfigured something or implementation still needs a tweak.
(note: we haven't checked if this problem only occur on plan-preview or not.)
What you expected to happen: should succeed plan-preview (and any other procedure)
How to reproduce it:
pipectl plan-preview
or trigger the plan-preview action against itEnvironment:
piped
version: v0.50.2control-plane
version: v0.50.2The text was updated successfully, but these errors were encountered: