Skip to content

[v1] Disabled pipeds are listed in app register form #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
t-kikuc opened this issue Feb 19, 2025 · 3 comments · Fixed by #5590
Closed

[v1] Disabled pipeds are listed in app register form #5585

t-kikuc opened this issue Feb 19, 2025 · 3 comments · Fixed by #5590
Assignees
Labels
kind/bug Something isn't working as expected

Comments

@t-kikuc
Copy link
Member

t-kikuc commented Feb 19, 2025

What happened:

Image

What you expected to happen:

disabled pipeds are not shown on the form

How to reproduce it:

  1. Disable a piped
  2. Open the app register form (v1)
  3. Click the piped selection box and you'll see the disabled piped

Environment:

  • piped version:
  • control-plane version:
  • Others:
@t-kikuc t-kikuc added the kind/bug Something isn't working as expected label Feb 19, 2025
@t-kikuc
Copy link
Member Author

t-kikuc commented Feb 19, 2025

@hongky-1994
I think the following filter is needed in v1 👍

const pipedOptions = useMemo(() => {
return ps
.filter((piped) => !piped.disabled)
.sort((a, b) => sortFunc(a.name, b.name));
}, [ps]);

@hongky-1994
Copy link
Contributor

Thanks, @t-kikuc , I have created a PR #5590 to fix these bugs.
Also, I found that when editing an application, which is using disabled piped, show piped input select with blank option because of filter disabled piped. So I keep piped options item of application currently used evenwhen it is disabled.

@t-kikuc
Copy link
Member Author

t-kikuc commented Feb 20, 2025

@hongky-1994 Thank you so much! I merged the PR

Also, I found that when editing an application,

we had not noticed that! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants