Skip to content

Commit 874278e

Browse files
authored
Change fields on deployment trace model to be not required (#5619)
* Change fields on deployment trace model to be not required Signed-off-by: khanhtc1202 <[email protected]> * Fix lint Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: khanhtc1202 <[email protected]>
1 parent 04394f5 commit 874278e

File tree

6 files changed

+27
-104
lines changed

6 files changed

+27
-104
lines changed

pkg/model/deployment_trace.pb.go

Lines changed: 23 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/model/deployment_trace.pb.validate.go

Lines changed: 2 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/model/deployment_trace.proto

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,13 @@ import "validate/validate.proto";
2121

2222
message DeploymentTrace {
2323
string id = 1 [(validate.rules).string.min_len = 1];
24-
string title = 2 [(validate.rules).string.min_len = 1];
24+
string title = 2;
2525
string commit_hash = 3 [(validate.rules).string.min_len = 1];
2626
string commit_url = 4 [(validate.rules).string.min_len = 1];
2727
string commit_message = 5;
2828
int64 commit_timestamp = 6 [(validate.rules).int64.gte = 0];
29-
string author = 7 [(validate.rules).string.min_len = 1];
29+
string author = 7;
3030

31-
int64 completed_at = 100 [(validate.rules).int64.gte = 0];
3231
int64 created_at = 101 [(validate.rules).int64.gte = 0];
3332
int64 updated_at = 102 [(validate.rules).int64.gte = 0];
3433
}

web/model/deployment_trace_pb.d.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@ export class DeploymentTrace extends jspb.Message {
2525
getAuthor(): string;
2626
setAuthor(value: string): DeploymentTrace;
2727

28-
getCompletedAt(): number;
29-
setCompletedAt(value: number): DeploymentTrace;
30-
3128
getCreatedAt(): number;
3229
setCreatedAt(value: number): DeploymentTrace;
3330

@@ -51,7 +48,6 @@ export namespace DeploymentTrace {
5148
commitMessage: string,
5249
commitTimestamp: number,
5350
author: string,
54-
completedAt: number,
5551
createdAt: number,
5652
updatedAt: number,
5753
}

web/model/deployment_trace_pb.js

Lines changed: 0 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

web/src/__fixtures__/dummy-deployment-trace.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ export const dummyDeploymentTrace: ListDeploymentTracesResponse.DeploymentTraceR
1515
commitUrl: "commit-url",
1616
createdAt: createdAt.unix(),
1717
updatedAt: completedAt.unix(),
18-
completedAt: completedAt.unix(),
1918
},
2019
deploymentsList: [dummyDeployment],
2120
};

0 commit comments

Comments
 (0)