Skip to content

Commit 360606b

Browse files
committed
Following consensus on: serde-rs#2580 (review)
This PR phases out the precompiled per final consensus made in serde-rs#2580 i# Fix a cfg
1 parent 151b45a commit 360606b

33 files changed

+3
-1607
lines changed

.github/workflows/ci.yml

+1-23
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ jobs:
9898
- run: cd serde && cargo check --no-default-features
9999
- run: cd serde && cargo check
100100
- run: cd serde_derive && cargo check
101-
- run: cd precompiled/serde_derive && cargo check
102101

103102
alloc:
104103
name: Rust 1.36.0
@@ -109,35 +108,14 @@ jobs:
109108
- uses: dtolnay/[email protected]
110109
- run: cd serde && cargo build --no-default-features --features alloc
111110

112-
precompiled:
113-
name: Precompiled
114-
runs-on: ubuntu-latest
115-
timeout-minutes: 45
116-
steps:
117-
- uses: actions/checkout@v3
118-
- uses: dtolnay/rust-toolchain@nightly
119-
with:
120-
components: rust-src
121-
targets: x86_64-unknown-linux-musl
122-
- run: precompiled/build.sh
123-
- name: replace serde_derive dependency with precompiled
124-
run: |
125-
cargo rm serde_derive --package serde
126-
cargo rm serde_derive --package serde --dev
127-
sed -i '/"serde_derive"/d' Cargo.toml
128-
sed -i '/\[workspace\]/d' precompiled/serde_derive/Cargo.toml
129-
cargo add --dev serde_derive --path precompiled/serde_derive --package serde_test_suite
130-
git diff
131-
- run: cd test_suite && cargo test --features unstable -- --skip ui --exact
132-
133111
macos:
134112
name: macOS
135113
runs-on: macos-latest
136114
timeout-minutes: 45
137115
steps:
138116
- uses: actions/checkout@v3
139117
- uses: dtolnay/rust-toolchain@stable
140-
- run: cd precompiled/serde_derive && cargo check
118+
- run: cd serde_derive && cargo check
141119

142120
minimal:
143121
name: Minimal versions

precompiled/.gitignore

-1
This file was deleted.

precompiled/Cargo.toml

-14
This file was deleted.

precompiled/bin/Cargo.toml

-17
This file was deleted.

precompiled/bin/build.rs

-4
This file was deleted.

precompiled/bin/main.rs

-45
This file was deleted.

precompiled/bin/src

-1
This file was deleted.

precompiled/build.sh

-19
This file was deleted.

precompiled/proc-macro2/Cargo.toml

-8
This file was deleted.

0 commit comments

Comments
 (0)