fix(modal): should not get value property when modal is undefined #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 thanks for sending this in, @YvonneYu. |
jbrowning
added a commit
that referenced
this pull request
Oct 13, 2015
fix(modal): should not get value property when modal is undefined
jbrowning
added a commit
that referenced
this pull request
Oct 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We found out that it will though exception by calling 'value' property when no modal instance exist.
exception: TypeError: Cannot read property 'value' of undefined
Moreover, we found out there is similar issue for angular-bootstrap. Thus, the same fixed will fix in angualr-foundation as well.
angular-ui/bootstrap#1972
Hope it help. Thank you