WIP: v8

Author: wesleytodd

index.js

@@ -596,10 +596,9 @@ function processParams (params, layer, called, req, res, done) {
 
     paramIndex = 0
     key = keys[i++]
-    name = key.name
-    paramVal = req.params[name]
-    paramCallbacks = params[name]
-    paramCalled = called[name]
+    paramVal = req.params[key]
+    paramCallbacks = params[key]
+    paramCalled = called[key]
 
     if (paramVal === undefined || !paramCallbacks) {
       return param()
@@ -609,13 +608,13 @@ function processParams (params, layer, called, req, res, done) {
     if (paramCalled && (paramCalled.match === paramVal ||
       (paramCalled.error && paramCalled.error !== 'route'))) {
       // restore value
-      req.params[name] = paramCalled.value
+      req.params[key] = paramCalled.value
 
       // next param
       return param(paramCalled.error)
     }
 
-    called[name] = paramCalled = {
+    called[key] = paramCalled = {
       error: null,
       match: paramVal,
       value: paramVal
@@ -629,7 +628,7 @@ function processParams (params, layer, called, req, res, done) {
     var fn = paramCallbacks[paramIndex++]
 
     // store updated value
-    paramCalled.value = req.params[key.name]
+    paramCalled.value = req.params[key]
 
     if (err) {
       // store error
@@ -641,7 +640,7 @@ function processParams (params, layer, called, req, res, done) {
     if (!fn) return param()
 
     try {
-      var ret = fn(req, res, paramCallback, paramVal, key.name)
+      var ret = fn(req, res, paramCallback, paramVal, key)
       if (isPromise(ret)) {
         ret.then(null, function (error) {
           paramCallback(error || new Error('Rejected promise'))

lib/layer.js

@@ -20,8 +20,8 @@ var pathRegexp = require('path-to-regexp')
  * @private
  */
 
-var hasOwnProperty = Object.prototype.hasOwnProperty
 var TRAILING_SLASH_REGEXP = /\/+$/
+var MATCHING_GROUP_REGEXP = /\((?:\?<(.*?)>)?(?!\?)/g
 
 /**
  * Expose `Layer`.
@@ -41,10 +41,53 @@ function Layer (path, options, fn) {
   this.name = fn.name || '<anonymous>'
   this.params = undefined
   this.path = undefined
-  this.regexp = pathRegexp((opts.strict ? path : loosen(path)), this.keys, opts)
+  this.slash = path === '/' && opts.end === false
+
+  function matcher (_path) {
+    if (_path instanceof RegExp) {
+      debugger
+      var keys = []
+      var name = 0
+      var m
+      while (m = MATCHING_GROUP_REGEXP.exec(_path.source)) {
+        keys.push({
+          name: m[1] || name++,
+          offset: m.index
+        })
+      }
+  
+      return function regexpMatcher (p) {
+        var match = _path.exec(p)
+        if (!match) {
+          return false
+        }
+
+        var params = {}
+        for (var i = 1; i < match.length; i++) {
+          var key = keys[i - 1]
+          var prop = key.name
+          var val = decodeParam(match[i])
+      
+          if (val !== undefined || !(hasOwnProperty.call(params, prop))) {
+            params[prop] = val
+          }
+        }
+
+        return {
+          params: params,
+          path: p
+        }
+      }
+    }
 
-  // set fast path flags
-  this.regexp._slash = path === '/' && opts.end === false
+    return pathRegexp.match((opts.strict ? _path : loosen(_path)), {
+      sensitive: opts.sensitive,
+      end: opts.end,
+      trailing: !opts.strict,
+      decode: decodeParam
+    })
+  }
+  this.matchers = Array.isArray(path) ? path.map(matcher) : [matcher(path)]
 }
 
 /**
@@ -123,17 +166,20 @@ Layer.prototype.handleRequest = function handleRequest (req, res, next) {
 
 Layer.prototype.match = function match (path) {
   var match
-
   if (path != null) {
     // fast path non-ending match for / (any path matches)
-    if (this.regexp._slash) {
+    if (this.slash) {
       this.params = {}
       this.path = ''
       return true
     }
 
-    // match the path
-    match = this.regexp.exec(path)
+    var i = 0;
+    while (!match && i < this.matchers.length) {
+      // match the path
+      match = this.matchers[i](path)
+      i++;
+    }
   }
 
   if (!match) {
@@ -143,22 +189,9 @@ Layer.prototype.match = function match (path) {
   }
 
   // store values
-  this.params = {}
-  this.path = match[0]
-
-  // iterate matches
-  var keys = this.keys
-  var params = this.params
-
-  for (var i = 1; i < match.length; i++) {
-    var key = keys[i - 1]
-    var prop = key.name
-    var val = decodeParam(match[i])
-
-    if (val !== undefined || !(hasOwnProperty.call(params, prop))) {
-      params[prop] = val
-    }
-  }
+  this.params = match.params
+  this.path = match.path
+  this.keys = Object.keys(match.params)
 
   return true
 }
@@ -192,7 +225,7 @@ function decodeParam (val) {
  * Loosens the given path for path-to-regexp matching.
  */
 function loosen (path) {
-  if (path instanceof RegExp) {
+  if (path instanceof RegExp || path === '/') {
     return path
   }
 

package.json

@@ -29,6 +29,7 @@
     "finalhandler": "1.2.0",
     "mocha": "10.2.0",
     "nyc": "15.1.0",
+    "run-series": "^1.1.9",
     "safe-buffer": "5.2.1",
     "supertest": "6.3.3"
   },
@@ -46,6 +47,7 @@
   "scripts": {
     "lint": "eslint .",
     "test": "mocha --reporter spec --bail --check-leaks test/",
+    "test:debug": "mocha --reporter spec --bail --check-leaks test/ --inspect --inspect-brk",
     "test-ci": "nyc --reporter=lcov --reporter=text npm test",
     "test-cov": "nyc --reporter=text npm test",
     "version": "node scripts/version-history.js && git add HISTORY.md"

test/param.js

@@ -1,5 +1,6 @@
 
 var after = require('after')
+var series = require('run-series')
 var Router = require('..')
 var utils = require('./support/utils')
 
@@ -300,7 +301,6 @@ describe('Router', function () {
 
     describe('next("route")', function () {
       it('should cause route with param to be skipped', function (done) {
-        var cb = after(3, done)
         var router = new Router()
         var server = createServer(router)
 
@@ -326,17 +326,23 @@ describe('Router', function () {
           res.end('cannot get a new user')
         })
 
-        request(server)
-          .get('/user/2')
-          .expect(200, 'get user 2', cb)
-
-        request(server)
-          .get('/user/bob')
-          .expect(404, cb)
-
-        request(server)
-          .get('/user/new')
-          .expect(400, 'cannot get a new user', cb)
+        series([
+          function (cb) {
+            request(server)
+              .get('/user/2')
+              .expect(200, 'get user 2', cb)
+          },
+          function (cb) {
+            request(server)
+              .get('/user/bob')
+              .expect(404, cb)
+          },
+          function (cb) {
+            request(server)
+              .get('/user/new')
+              .expect(400, 'cannot get a new user', cb)
+          }
+        ], done)
       })
 
       it('should invoke fn if path value differs', function (done) {

test/req.params.js

@@ -124,46 +124,6 @@ describe('req.params', function () {
         .expect('x-params-1', '{"foo":"buzz"}')
         .expect(200, '{"foo":"bar"}', done)
     })
-
-    describe('with numeric properties in req.params', function () {
-      it('should merge numeric properties by offsetting', function (done) {
-        var router = Router({ mergeParams: true })
-        var server = createServer(function (req, res, next) {
-          req.params = { 0: 'foo', 1: 'bar' }
-
-          router(req, res, function (err) {
-            if (err) return next(err)
-            sawParams(req, res)
-          })
-        })
-
-        router.get('/(.*)', hitParams(1))
-
-        request(server)
-          .get('/buzz')
-          .expect('x-params-1', '{"0":"foo","1":"bar","2":"buzz"}')
-          .expect(200, '{"0":"foo","1":"bar"}', done)
-      })
-
-      it('should merge with same numeric properties', function (done) {
-        var router = Router({ mergeParams: true })
-        var server = createServer(function (req, res, next) {
-          req.params = { 0: 'foo' }
-
-          router(req, res, function (err) {
-            if (err) return next(err)
-            sawParams(req, res)
-          })
-        })
-
-        router.get('/(.*)', hitParams(1))
-
-        request(server)
-          .get('/bar')
-          .expect('x-params-1', '{"0":"foo","1":"bar"}')
-          .expect(200, '{"0":"foo"}', done)
-      })
-    })
   })
 })