Fix decoding filenames from Chrome/Firefox

fixes #252

Author: dougwilson

HISTORY.md

@@ -1,6 +1,7 @@
 unreleased
 ==========
 
+  * Fix decoding filenames from Chrome/Firefox
   * Fix form parsing when no `part` event listener added
   * deps: [email protected]
     - deps: [email protected]

index.js

@@ -836,7 +836,7 @@ function parseFilename(headerValue) {
 
   var filename = m[1] || m[2] || '';
   filename = filename.replace(/%22|\\"/g, '"');
-  filename = filename.replace(/&#([\d]{4});/g, function(m, code) {
+  filename = filename.replace(/&#([0-9]{1,5});/g, function(m, code) {
     return String.fromCharCode(code);
   });
   return filename.substr(filename.lastIndexOf('\\') + 1);

test/fixture/http/special-chars-in-filename/issue-252-chrome.http

@@ -0,0 +1,16 @@
+POST /upload HTTP/1.1
+Host: localhost:8080
+Content-Length: 363
+Content-Type: multipart/form-data; boundary=----WebKitFormBoundarytyE4wkKlZ5CQJVTG
+
+------WebKitFormBoundarytyE4wkKlZ5CQJVTG
+Content-Disposition: form-data; name="title"
+
+Weird filename
+------WebKitFormBoundarytyE4wkKlZ5CQJVTG
+Content-Disposition: form-data; name="upload"; filename="JΛ̊KE_2023-02-25T16:44:24.129Z.txt"
+Content-Type: text/plain
+
+I am a text file with a funky name!
+
+------WebKitFormBoundarytyE4wkKlZ5CQJVTG--

test/fixture/js/special-chars-in-filename.js

@@ -20,6 +20,18 @@ var webkit = " ? % * | \" < > . ? ; ' @ # $ ^ & ( ) - _ = + { } [ ] ` ~.txt";
 var ffOrIe = " ? % * | \" < > . ☃ ; ' @ # $ ^ & ( ) - _ = + { } [ ] ` ~.txt";
 
 module.exports = {
+  'issue-252-chrome.http' : [
+    {
+      type: 'field',
+      name: 'title',
+      value: 'Weird filename'
+    },
+    {
+      type: 'file',
+      name: 'upload',
+      filename: 'JΛ̊KE_2023-02-25T16:44:24.129Z.txt'
+    }
+  ],
   'osx-chrome-13.http'   : expect(webkit),
   'osx-firefox-3.6.http' : expect(ffOrIe),
   'osx-safari-5.http'    : expect(webkit),