Skip to content

Remove obsolete "version" value from example docker-compose.yml in README.md #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
lemondjeff opened this issue Apr 1, 2024 · 1 comment
Closed
1 task done
Labels

Comments

@lemondjeff
Copy link
Contributor

This is a: Bug

Details

Version in docker-compose.yml files has been obsolete for quite some time now. Per the documentation:

Compose doesn't use version to select an exact schema to validate the Compose file, but prefers the most recent schema when it's implemented.

Related Issues

  • I have searched this repository/Pi-hole forums for existing issues and pull requests that look similar

How to reproduce the issue

View docker-pi-hole's README.md and note that the example docker-compose.yml includes an unnecessary version entry.

@lemondjeff lemondjeff changed the title Remove obsolete "version" value from example docker-compose.yml README.md Remove obsolete "version" value from example docker-compose.yml in README.md Apr 1, 2024
Copy link

github-actions bot commented May 2, 2024

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant