Add regression test for #1924

jlherren · ondrejmirtes · commit c431e385010e · 2020-10-18T11:13:29.000+02:00
diff --git a/tests/PHPStan/Rules/Comparison/data/boolean-and.php b/tests/PHPStan/Rules/Comparison/data/boolean-and.php
@@ -149,3 +149,18 @@ public function andInIfCondition($mixed, int $i): void
 		}
 	}
 }
+
+function getMaybeArray() : ?array {
+	if (rand(0, 1)) { return [1, 2, 3]; }
+	return null;
+}
+
+function bug1924() {
+	$arr = [
+		'a' => getMaybeArray(),
+		'b' => getMaybeArray(),
+	];
+
+	if (isset($arr['a']) && isset($arr['b'])) {
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -149,3 +149,18 @@ public function andInIfCondition($mixed, int $i): void`
`149`	`149`	`}`
`150`	`150`	`}`
`151`	`151`	`}`
	`152`	`+`
	`153`	`+function getMaybeArray() : ?array {`
	`154`	`+ if (rand(0, 1)) { return [1, 2, 3]; }`
	`155`	`+ return null;`
	`156`	`+}`
	`157`	`+`
	`158`	`+function bug1924() {`
	`159`	`+ $arr = [`
	`160`	`+ 'a' => getMaybeArray(),`
	`161`	`+ 'b' => getMaybeArray(),`
	`162`	`+ ];`
	`163`	`+`
	`164`	`+ if (isset($arr['a']) && isset($arr['b'])) {`
	`165`	`+ }`
	`166`	`+}`