Fix SimpleXMLElement iterable type on PHP 8

Author: ondrejmirtes

composer.json

@@ -25,7 +25,7 @@
 		"ondram/ci-detector": "^3.4.0",
 		"ondrejmirtes/better-reflection": "4.3.37",
 		"phpdocumentor/reflection-docblock": "4.3.4",
-		"phpstan/php-8-stubs": "^0.1.4",
+		"phpstan/php-8-stubs": "^0.1.5",
 		"phpstan/phpdoc-parser": "^0.4.9",
 		"react/child-process": "^0.6.1",
 		"react/event-loop": "^1.1",

composer.lock

@@ -10239,7 +10239,7 @@
 'SimpleXMLElement::getNamespaces' => ['string[]', 'recursive='=>'bool'],
 'SimpleXMLElement::registerXPathNamespace' => ['bool', 'prefix'=>'string', 'ns'=>'string'],
 'SimpleXMLElement::xpath' => ['SimpleXMLElement[]|false', 'path'=>'string'],
-'SimpleXMLIterator::current' => ['SimpleXMLIterator|null'],
+'SimpleXMLIterator::current' => ['SimpleXMLIterator'],
 'SimpleXMLIterator::getChildren' => ['SimpleXMLIterator'],
 'SimpleXMLIterator::hasChildren' => ['bool'],
 'SimpleXMLIterator::key' => ['string|false'],

resources/functionMap.php

@@ -13,7 +13,7 @@ class SimpleXMLElementClassPropertyReflectionExtension implements PropertiesClas
 
 	public function hasProperty(ClassReflection $classReflection, string $propertyName): bool
 	{
-		return $classReflection->getName() === 'SimpleXMLElement';
+		return $classReflection->getName() === 'SimpleXMLElement' || $classReflection->isSubclassOf('SimpleXMLElement');
 	}
 
 

src/Type/Php/SimpleXMLElementClassPropertyReflectionExtension.php

@@ -422,4 +422,11 @@ public function testMixin(): void
 		]);
 	}
 
+	public function testBug3947(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkUnionTypes = true;
+		$this->analyse([__DIR__ . '/data/bug-3947.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Properties/AccessPropertiesRuleTest.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Bug3947;
+
+class HelloWorld
+{
+	public function sayHello(\SimpleXMLElement $item): void
+	{
+		foreach ($item->items->children() as $groupItem) {
+			switch ((string)$groupItem->orderType) {
+			}
+		}
+	}
+}