Fix explode() tests on PHP 8

Author: ondrejmirtes

src/Type/Php/ExplodeFunctionDynamicReturnTypeExtension.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node\Expr\FuncCall;
 use PHPStan\Analyser\Scope;
+use PHPStan\Php\PhpVersion;
 use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\Accessory\NonEmptyArrayType;
@@ -13,6 +14,7 @@
 use PHPStan\Type\IntegerRangeType;
 use PHPStan\Type\IntegerType;
 use PHPStan\Type\MixedType;
+use PHPStan\Type\NeverType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
@@ -21,6 +23,13 @@
 class ExplodeFunctionDynamicReturnTypeExtension implements \PHPStan\Type\DynamicFunctionReturnTypeExtension
 {
 
+	private PhpVersion $phpVersion;
+
+	public function __construct(PhpVersion $phpVersion)
+	{
+		$this->phpVersion = $phpVersion;
+	}
+
 	public function isFunctionSupported(FunctionReflection $functionReflection): bool
 	{
 		return $functionReflection->getName() === 'explode';
@@ -39,6 +48,9 @@ public function getTypeFromFunctionCall(
 		$delimiterType = $scope->getType($functionCall->args[0]->value);
 		$isSuperset = (new ConstantStringType(''))->isSuperTypeOf($delimiterType);
 		if ($isSuperset->yes()) {
+			if ($this->phpVersion->getVersionId() >= 80000) {
+				return new NeverType();
+			}
 			return new ConstantBooleanType(false);
 		} elseif ($isSuperset->no()) {
 			$arrayType = new ArrayType(new IntegerType(), new StringType());

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -10187,6 +10187,10 @@ public function dataClassConstantOnExpression(): array
 
 	public function dataBug3961(): array
 	{
+		if (PHP_VERSION >= 80000) {
+			return $this->gatherAssertTypes(__DIR__ . '/data/bug-3961-php8.php');
+		}
+
 		return $this->gatherAssertTypes(__DIR__ . '/data/bug-3961.php');
 	}
 

tests/PHPStan/Analyser/data/bug-3961-php8.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace Bug3961Php8;
+
+use function PHPStan\Analyser\assertType;
+
+class Foo
+{
+
+	public function doFoo(string $v, string $d, $m): void
+	{
+		assertType('array<int, string>&nonEmpty', explode('.', $v));
+		assertType('*NEVER*', explode('', $v));
+		assertType('array<int, string>', explode('.', $v, -2));
+		assertType('array<int, string>&nonEmpty', explode('.', $v, 0));
+		assertType('array<int, string>&nonEmpty', explode('.', $v, 1));
+		assertType('array<int, string>', explode($d, $v));
+		assertType('array<int, string>', explode($m, $v));
+	}
+
+}