More useful behaviour of "some jobs remaining"

ondrejmirtes · ondrejmirtes · commit 6c61e497f692 · 2020-10-02T14:49:56.000+02:00
diff --git a/src/Parallel/ParallelAnalyser.php b/src/Parallel/ParallelAnalyser.php
@@ -198,7 +198,8 @@ public function analyse(
 		$loop->run();
 
 		if (count($jobs) > 0) {
-			throw new \PHPStan\ShouldNotHappenException('Some jobs remaining');
+			$internalErrors[] = 'Some parallel worker jobs have not finished';
+			$internalErrorsCount++;
 		}
 
 		return new AnalyserResult(

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,8 @@ public function analyse(`
`198`	`198`	`$loop->run();`
`199`	`199`
`200`	`200`	`if (count($jobs) > 0) {`
`201`		`- throw new \PHPStan\ShouldNotHappenException('Some jobs remaining');`
	`201`	`+ $internalErrors[] = 'Some parallel worker jobs have not finished';`
	`202`	`+ $internalErrorsCount++;`
`202`	`203`	`}`
`203`	`204`
`204`	`205`	`return new AnalyserResult(`