Fix scale parameter check in bc math return type extension

Author: jaroslavlibal

src/Type/Php/BcMathStringOrNullReturnTypeExtension.php

@@ -60,7 +60,7 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 		$thirdArgument = $scope->getType($functionCall->args[2]->value);
 		$thirdArgumentIsNumeric = ($thirdArgument instanceof ConstantScalarType && is_numeric($thirdArgument->getValue())) || $thirdArgument instanceof IntegerType;
 
-		if ($thirdArgument instanceof ConstantScalarType && ($this->isZero($thirdArgument->getValue()) || !is_numeric($thirdArgument->getValue()))) {
+		if ($thirdArgument instanceof ConstantScalarType && !is_numeric($thirdArgument->getValue())) {
 			return new NullType();
 		}
 

tests/PHPStan/Analyser/data/bcmath-dynamic-return.php

@@ -23,6 +23,8 @@
 \PHPStan\Analyser\assertType('null', bcdiv('10', 0.0)); // Warning: Division by zero
 \PHPStan\Analyser\assertType('string', bcdiv('10', '1'));
 \PHPStan\Analyser\assertType('string', bcdiv('10', '-1'));
+\PHPStan\Analyser\assertType('string', bcdiv('10', '2', 0));
+\PHPStan\Analyser\assertType('string', bcdiv('10', '2', 1));
 \PHPStan\Analyser\assertType('string', bcdiv('10', $iNeg));
 \PHPStan\Analyser\assertType('string', bcdiv('10', $iPos));
 \PHPStan\Analyser\assertType('string', bcdiv($iPos, $iPos));
@@ -38,6 +40,8 @@
 \PHPStan\Analyser\assertType('null', bcmod($iPos, '0')); // Warning: Division by zero
 \PHPStan\Analyser\assertType('null', bcmod('10', $nonNumeric));
 \PHPStan\Analyser\assertType('string', bcmod('10', '1'));
+\PHPStan\Analyser\assertType('string', bcmod('10', '2', 0));
+\PHPStan\Analyser\assertType('string', bcmod('5.7', '1.3', 1));
 \PHPStan\Analyser\assertType('string', bcmod('10', 2.2));
 \PHPStan\Analyser\assertType('string', bcmod('10', $iUnknown));
 \PHPStan\Analyser\assertType('string', bcmod('10', '-1'));