Do not inherit constructor PHPDocs from internal classes

Author: ondrejmirtes

src/PhpDoc/PhpDocInheritanceResolver.php

@@ -77,6 +77,13 @@ private function docBlockTreeToResolvedDocBlock(PhpDocBlock $phpDocBlock, ?strin
 		$parentPhpDocBlocks = [];
 
 		foreach ($phpDocBlock->getParents() as $parentPhpDocBlock) {
+			if (
+				$parentPhpDocBlock->getClassReflection()->isBuiltin()
+				&& $functionName !== null
+				&& strtolower($functionName) === '__construct'
+			) {
+				continue;
+			}
 			$parents[] = $this->docBlockTreeToResolvedDocBlock(
 				$parentPhpDocBlock,
 				$parentPhpDocBlock->getTrait(),

tests/PHPStan/Rules/Classes/InstantiationRuleTest.php

@@ -264,4 +264,9 @@ public function testOldStyleConstructorOnPhp7(): void
 		$this->analyse([__DIR__ . '/data/php80-constructor.php'], $errors);
 	}
 
+	public function testBug4030(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-4030.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Classes/data/bug-4030.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Bug4011;
+
+class Foo extends \FilterIterator
+{
+	public function __construct(\Traversable $iterator)
+	{
+
+	}
+
+	public function accept()
+	{
+		return true;
+	}
+}
+
+function (\Traversable $t) {
+	new Foo($t);
+};

tests/PHPStan/Rules/Methods/IncompatibleDefaultParameterTypeRuleTest.php

@@ -35,4 +35,9 @@ public function testTraitCrash(): void
 		$this->analyse([__DIR__ . '/data/incompatible-default-parameter-type-trait-crash.php'], []);
 	}
 
+	public function testBug4011(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-4011.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Methods/data/bug-4011.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Bug4011;
+
+class ParseException extends \Exception
+{
+	public function __construct(string $message = '', $code = '')
+	{
+
+	}
+}