'Manager' is not descriptive or unique enough. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

MaxHasADHD opened this issue Jul 11, 2018 · 1 comment

Labels

MaxHasADHD commented Jul 11, 2018

I think 'Manager' is too vague, not a huge issue but 'CallbackManager' or something would be more helpful.

Owner

phimage commented Jul 11, 2018

I think you are right. Could be boring with import.
There is no syntax import class CallbackURLKit.Manager as CallbackManager

For others projects when I have some collision I put in one specific file, and sometimes it do the job

import CallbackURLKit
typealias CallbackManager = Manager

phimage added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment