Merge branch 'Pharo7.0' into 22830-Object-centric-metalink-integration

Author: StevenCostiou

CONTRIBUTING.md

@@ -8,21 +8,15 @@ If you found a bug or issue with Pharo please let us know. You can report bugs o
 ### How to report a bug
 *  Take the latest stable or latest development system, ideally using the latest virtual machine is better (check [download](https://pharo.org/download) page).
 *  Make sure that you can reproduce the bug.
-*  Send a mail to the mailing-list pharo-dev mailing if you are not sure, check if the bug was already reported on https://pharo.manuscript.com/
-*  Open a bug entry on https://pharo.manuscript.com/
+*  Send a mail to the mailing-list pharo-dev mailing if you are not sure, check if the bug was already reported on https://github.com/pharo-project/pharo/issues
+*  Open a bug entry on https://github.com/pharo-project/pharo/issues
 *  Do not forget to mention the virtual machine version, your OS and other crucial information
 *  Follow your bug. Indeed it may happen that your bug is fixed by introducing another bug fix and you can verify and close it.
 *  Watch the video from the [Pharo TechTalk February 2018](https://www.youtube.com/watch?v=VW7XrFjnbyw) for a step by step tutorial.
 
 ### How to propose a bug fix or enhancement
 
-First check if your change has already been entered into [Manuscript](https://pharo.manuscript.com/), and consider watching the [overview video](https://vimeo.com/162493974) of the steps documented below. (Manuscript used to be called Fugbugz, you will see this old name used a lot instead)
-
-#### Prerequisites
-
-In order to propose a bug fix or enhancement for Pharo you need:
-
-- An account for the [Manuscript Pharo Issue Tracker](https://pharo.manuscript.com/), so that you can change the status of an issue. This status changes is important because it will launches the monkey (a robot that will load and run the tests automatically).
+First check if your change has already been entered into the [issue tracker](https://github.com/pharo-project/pharo/issues), and consider watching the [overview video](https://vimeo.com/162493974) of the steps documented below. 
 
 #### Pharo 70 and git
 
@@ -43,7 +37,7 @@ You also need an account on [SmalltalkHub](http://smalltalkhub.com/) with comm
 In summary you will do the following:
 
 - Take the latest stable or latest development system, ideally using the latest virtual machine (check the [downloads](https://pharo.org/download)).
-- Do a fix for a given bug, or a new bug you entered on the [Manuscript issue tracker](https://pharo.manuscript.com/).
+- Do a fix for a given bug, or a new bug you entered on the [issue tracker](https://github.com/pharo-project/pharo/issues).
 - Create a code fix (ideally with a unit test exercising the working code)
 - Create a slice (group of packages):
     - Open the Monticello Browser.

Jenkinsfile

@@ -30,10 +30,22 @@ def shell(params){
 def runTests(architecture, prefix=''){
   cleanWs()
   dir(env.STAGE_NAME) {
-    unstash "bootstrap${architecture}"
-    shell "bash -c 'bootstrap/scripts/run${prefix}Tests.sh ${architecture} ${env.STAGE_NAME}'"
-    junit allowEmptyResults: true, testResults: "${env.STAGE_NAME}*.xml"
-    archiveArtifacts allowEmptyArchive: true, artifacts: "${env.STAGE_NAME}*.xml", fingerprint: true
+    try {
+        unstash "bootstrap${architecture}"
+        shell "bash -c 'bootstrap/scripts/run${prefix}Tests.sh ${architecture} ${env.STAGE_NAME}'"
+        junit allowEmptyResults: true, testResults: "${env.STAGE_NAME}*.xml"
+        archiveArtifacts allowEmptyArchive: true, artifacts: "${env.STAGE_NAME}*.xml", fingerprint: true
+    }finally{
+        // I am archiving the logs to check for crashes and errors.
+        if(fileExists('PharoDebug.log')){
+            shell "mv PharoDebug.log PharoDebug-${env.STAGE_NAME}.log"
+            archiveArtifacts allowEmptyArchive: true, artifacts: "PharoDebug-${env.STAGE_NAME}.log", fingerprint: true
+        }
+        if(fileExists('crash.dmp')){
+            shell "mv crash.dmp crash-${env.STAGE_NAME}.dmp"
+            archiveArtifacts allowEmptyArchive: true, artifacts: "crash-${env.STAGE_NAME}.dmp", fingerprint: true
+        }
+    }
   }
 }
 

bootstrap/scripts/4-build.sh

@@ -216,7 +216,7 @@ ${VM} "${PHARO_IMAGE_NAME}.image" "${IMAGE_FLAGS}" eval --save "Smalltalk vm par
 
 env 2>&1 > env.log
 
-${VM} "${PHARO_IMAGE_NAME}.image" "${IMAGE_FLAGS}" eval --save "Metacello new baseline: 'Tonel';repository: 'github://pharo-vcs/tonel:v1.0.11';onWarning: [ :e | Error signal: e messageText in: e signalerContext ]; load: 'core'"
+${VM} "${PHARO_IMAGE_NAME}.image" "${IMAGE_FLAGS}" eval --save "Metacello new baseline: 'Tonel';repository: 'github://pharo-vcs/tonel:v1.0.12';onWarning: [ :e | Error signal: e messageText in: e signalerContext ]; load: 'core'"
 ${VM} "${PHARO_IMAGE_NAME}.image" "${IMAGE_FLAGS}" eval --save "Metacello new baseline: 'Pharo';repository: 'tonel://${BOOTSTRAP_REPOSITORY}/src';onWarning: [ :e | Error signal: e messageText in: e signalerContext ]; load"
 ${VM} "${PHARO_IMAGE_NAME}.image" "${IMAGE_FLAGS}" eval --save "FFIMethodRegistry resetAll. PharoSourcesCondenser condenseNewSources. Smalltalk garbageCollect"
 ${VM} "${PHARO_IMAGE_NAME}.image" "${IMAGE_FLAGS}" clean --release

bootstrap/scripts/upload_to_files.pharo.org.sh

@@ -4,7 +4,7 @@ set -ex
 
 # I will use the name of the image to determine the vm version (because file name is in the format Pharo7.0.0-rc1)
 #
-PHARO_NAME_PREFIX=$(find . -name "Pharo*.zip" | head -n 1 | cut -d'/' -f 2 | cut -d'-' -f 1-2)
+PHARO_NAME_PREFIX=$(find . -name "Pharo*-bootstrap*.zip" | head -n 1 | cut -d'/' -f 2 | cut -d'-' -f 1-2)
 PHARO_SHORT_VERSION=$(echo "${PHARO_NAME_PREFIX}" | cut -d'-' -f 1 | cut -c 6- | cut -d'.' -f 1-2 | sed 's/\.//')
 
 destDir="/appli/files.pharo.org/image/${PHARO_SHORT_VERSION}/"

bootstrap/src/BaselineOfPharoBootstrapProcess.package/BaselineOfPharoBootstrapProcess.class/instance/baseline..st

@@ -5,7 +5,7 @@ baseline: spec
 	spec for: #common do: [
 		spec blessing: #baseline.
 		spec baseline: 'Tonel' with: [ spec
-			repository: 'github://pharo-vcs/tonel:v1.0.11' ].
+			repository: 'github://pharo-vcs/tonel:v1.0.12' ].
 		spec baseline: 'Hermes' with: [ spec
 			repository: 'github://tesonep/hermes:v2.4.1';
   			loads: 'core' ].

src/AST-Core/BISimpleFormatter.class.st

@@ -81,11 +81,6 @@ BISimpleFormatter >> codeStream: anObject [
 	codeStream := anObject
 ]
 
-{ #category : #'public interface' }
-BISimpleFormatter >> containerWidth: anInteger [
-	"nothing done on purpose"
-]
-
 { #category : #'public interface' }
 BISimpleFormatter >> format: aParseTree [
 	originalSource := aParseTree source.

src/AST-Core/RBNullFormatter.class.st

@@ -30,11 +30,6 @@ RBNullFormatter class >> formatAsYouReadPolicy: aBoolean [
 	FormatAsYouReadPolicy := aBoolean
 ]
 
-{ #category : #'public interface' }
-RBNullFormatter >> containerWidth: anInteger [
-	"doing nothing on purpose"
-]
-
 { #category : #'public interface' }
 RBNullFormatter >> format: aParseTree [ 
 	^ aParseTree source

src/AST-Core/RBProgramNode.class.st

@@ -333,14 +333,7 @@ RBProgramNode >> evaluatedFirst: aNode [
 
 { #category : #accessing }
 RBProgramNode >> formattedCode [
-	^ self formattedCodeWithMaxLineLength: 70
-]
-
-{ #category : #accessing }
-RBProgramNode >> formattedCodeWithMaxLineLength: anInteger [
-	^ self formatterClass new
-		containerWidth: anInteger;
-		format: self
+	^ self formatterClass new format: self
 ]
 
 { #category : #accessing }

src/Athens-Cairo/CairoLibrary.class.st

@@ -21,7 +21,7 @@ CairoLibrary >> unix32ModuleName [
 	Look in a number of known locations, or LD_LIBRARY_PATH."
 
 	(#('/usr/lib/i386-linux-gnu' '/usr/lib32' '/usr/lib'),
-			(((OSEnvironment current getEnv: 'LD_LIBRARY_PATH') ifNil: [ '' ]) substrings: ':'))
+			((OSEnvironment current at: 'LD_LIBRARY_PATH' ifAbsent: [ '' ]) substrings: ':'))
 		do: [ :path | 
 			| libraryPath |
 			libraryPath := path asFileReference / 'libcairo.so.2'.
@@ -38,7 +38,7 @@ CairoLibrary >> unix64ModuleName [
 	Look in a number of known locations, or LD_LIBRARY_PATH."
 
 	(#('/lib/x86_64-linux-gnu' '/usr/lib'),
-			(((OSEnvironment current getEnv: 'LD_LIBRARY_PATH') ifNil: [ '' ]) substrings: ':'))
+			((OSEnvironment current at: 'LD_LIBRARY_PATH' ifAbsent: [ '' ]) substrings: ':'))
 		do: [ :path | 
 			| libraryPath |
 			libraryPath := path asFileReference / 'libcairo.so.2'.

src/BaselineOfIDE/BaselineOfIDE.class.st

@@ -156,6 +156,7 @@ BaselineOfIDE >> baseline: spec [
 
 		spec package: 'BlueInk-Core'.
 
+		spec package: 'Transcript-NonInteractive-Tests'.
 		spec package: 'Collections-Tests'.
 		spec package: 'Text-Tests'.
 		spec package: 'Network-Tests'.
@@ -314,6 +315,7 @@ BaselineOfIDE >> baseline: spec [
 		spec package: 'PerformMessageCommandLineHandler'.
 		spec package: 'Pharo-Help'.
 		spec package: 'PharoDocComment'.
+		spec package: 'PharoDocComment-Tests'.
 		spec package: 'Polymorph-Widgets-Rules'.
 		spec package: 'ProfStef-Tests'.
 		spec package: 'Random-Tests'.
@@ -477,6 +479,8 @@ spec group: 'General-Tests-Group' with: #(
 	'System-Identification-Tests'		
 	'System-DependenciesTests'
 	'System-BasicCommandLineHandler-Tests'
+	'Transcript-NonInteractive-Tests'
+	'PharoDocComment-Tests'	"standalone"
 ).	
 
 spec group: 'FuzzyMatcher-Core-Group' with: #(
@@ -841,7 +845,7 @@ BaselineOfIDE >> loadCalypso [
 
 	Metacello new
 		baseline: 'Calypso';
-		repository: 'github://pharo-ide/Calypso:v0.13.0/src';
+		repository: 'github://pharo-ide/Calypso:v0.14.2/src';
 		onConflict: [ :err | err useIncoming ];
 		onUpgrade: [ :err | err useIncoming ];
 		load: #('FullEnvironment' 'SystemBrowser' 'Tests').
@@ -855,7 +859,7 @@ BaselineOfIDE >> loadCalypso [
 BaselineOfIDE >> loadIceberg [
 	Metacello new
 		baseline: 'Iceberg';
-		repository: 'github://pharo-vcs/iceberg:v1.4.1';
+		repository: 'github://pharo-vcs/iceberg:v1.5.2';
 		load.
 	(Smalltalk classNamed: #Iceberg) enableMetacelloIntegration: true.
 	(Smalltalk classNamed: #IcePharoPlugin) addPharoProjectToIceberg.

src/BlueInk-Core/BIConfigurableFormatter.class.st

@@ -475,10 +475,9 @@ BIConfigurableFormatter >> bracketWith: bracketString around: aBlock [
 
 { #category : #private }
 BIConfigurableFormatter >> characterSeparatorMethodSignatureFor: aMethodNode [
-	^ [ 
-	(self needsMethodSignatureOnMultipleLinesFor: aMethodNode)
-		ifTrue: [ self newLine ]
-		ifFalse: [ self space ] ]
+	^ (self needsMethodSignatureOnMultipleLinesFor: aMethodNode)
+			ifTrue: [ self newLine ]
+			ifFalse: [ self space ]
 ]
 
 { #category : #accessing }
@@ -491,11 +490,6 @@ BIConfigurableFormatter >> codeStream: anObject [
 	codeStream := anObject
 ]
 
-{ #category : #'public interface' }
-BIConfigurableFormatter >> containerWidth: anInteger [
-	self installNewValueInContext: {(#maxLineLength: -> anInteger)}
-]
-
 { #category : #private }
 BIConfigurableFormatter >> currentLineLength [
 	^ codeStream position - lineStart
@@ -1213,7 +1207,7 @@ BIConfigurableFormatter >> privateFormatMethodPatternMonoLineFor: aMethodNode [
 			codeStream nextPutAll: key.
 			self space.
 			self visitNode: arg ]
-		separatedBy: (self characterSeparatorMethodSignatureFor: aMethodNode)
+		separatedBy: [ self characterSeparatorMethodSignatureFor: aMethodNode ]
 ]
 
 { #category : #private }
@@ -1233,7 +1227,7 @@ BIConfigurableFormatter >> privateFormatMethodPatternMultiLineFor: aMethodNode [
 			codeStream nextPutAll: key.
 			self space.
 			self visitNode: arg ]
-		separatedBy: (self characterSeparatorMethodSignatureFor: aMethodNode).
+		separatedBy: [ self characterSeparatorMethodSignatureFor: aMethodNode].
 	self newLines: 1
 ]
 
@@ -1447,6 +1441,16 @@ BIConfigurableFormatter >> visitLiteralNode: aLiteralNode [
 		ifTrue: [ self writeString: aLiteralNode sourceText ]
 ]
 
+{ #category : #visiting }
+BIConfigurableFormatter >> visitLiteralVariableNode: aLiteralVariableNode [
+	| binding |
+	binding := aLiteralVariableNode binding.
+	self writeString: binding key storeString, ' -> '.
+	aLiteralVariableNode binding value isLiteral
+		ifFalse: [ self writeString: '''<an unprintable nonliteral value>''' ]
+		ifTrue: [ self writeString:  binding value asString ]
+]
+
 { #category : #visiting }
 BIConfigurableFormatter >> visitMessageNode: aMessageNode [ 
 	self visitNode: aMessageNode receiver.

src/BlueInk-Extras/BISettingPreviewer.class.st

@@ -179,8 +179,7 @@ BISettingPreviewer >> formatSourceCode [
 	| source tree formatted |
 	source := self compiledMethodFromSearchFields sourceCode.
 	tree := RBParser parseMethod: source onError: [ :msg :pos | ^ self ].
-	formatted := tree
-		formattedCodeWithMaxLineLength: (self window value window value width / 9) integerPart asInteger.	"It is a bit tricky but I get the width of the sourceCodePane like this..."
+	formatted := tree formattedCode.
 	sourceCodePane text: formatted
 ]
 

src/CodeImportCommandLineHandlers/EvaluateCommandLineHandler.class.st

@@ -107,7 +107,7 @@ EvaluateCommandLineHandler >> evaluateArguments [
 { #category : #activation }
 EvaluateCommandLineHandler >> evaluateStdIn [
 	| stdin |
-	stdin := FileStream stdin ifNil: [ ^ self ].
+	stdin := Stdio stdin ifNil: [ ^ self ].
 	stdin atEnd  ifTrue: [ ^ self ].
 
 	self flag: #todo. "the whole compilation machinery does not work with stdin directly, hence we load everything a buffer first"

src/Colors/Color.class.st

@@ -1137,6 +1137,13 @@ Color >> basicPixelValueForDepth: d [
 	self error: 'unknown pixel depth: ' , d printString
 ]
 
+{ #category : #'accessing - higher level' }
+Color >> beOpaque [
+	"Set the transparency of the receiver to opaque, i.e. alpha to 1.0."
+	
+	^ self alpha: 1.0
+]
+
 { #category : #transformations }
 Color >> blacker [