Parse UTC timestamps with +00:00 offset

Previously, the timestamp parser would throw an exception if it received
a value with an offset of "+00:00". It would only work if the offset
were "+00". Now, it works with both formats.

[closes #320][#321]

Author: rafiss

src/main/java/io/r2dbc/postgresql/codec/PostgresqlDateTimeFormatter.java

@@ -48,7 +48,7 @@ class PostgresqlDateTimeFormatter {
             .appendFraction(NANO_OF_SECOND, 0, 9, true)
             .optionalEnd()
             .optionalStart()
-            .appendOffset("+HH:mm", "+00")
+            .appendOffset("+HH:mm", "+00:00")
             .optionalEnd()
             .toFormatter();
 

src/test/java/io/r2dbc/postgresql/codec/InstantCodecUnitTests.java

@@ -66,10 +66,23 @@ void decodeFromTimestampWithTimezone() {
         ZonedDateTime zonedDateTime = ZonedDateTime.parse("2018-11-05T00:20:25.039883+09:00[Asia/Tokyo]");
         Instant instant = zonedDateTime.toInstant();
 
+        assertThat(new InstantCodec(TEST).decode(encode(TEST, "2018-11-05 00:20:25.039883+09:00"), TIMESTAMPTZ.getObjectId(), FORMAT_TEXT, Instant.class))
+                .isEqualTo(instant);
         assertThat(new InstantCodec(TEST).decode(encode(TEST, "2018-11-05 00:20:25.039883+09"), TIMESTAMPTZ.getObjectId(), FORMAT_TEXT, Instant.class))
             .isEqualTo(instant);
     }
 
+    @Test
+    void decodeFromTimestampWithTimezoneUTC() {
+        ZonedDateTime zonedDateTime = ZonedDateTime.parse("2018-11-05T00:20:25.039883+00:00");
+        Instant instant = zonedDateTime.toInstant();
+
+        assertThat(new InstantCodec(TEST).decode(encode(TEST, "2018-11-05 00:20:25.039883+00:00"), TIMESTAMPTZ.getObjectId(), FORMAT_TEXT, Instant.class))
+                .isEqualTo(instant);
+        assertThat(new InstantCodec(TEST).decode(encode(TEST, "2018-11-05 00:20:25.039883+00"), TIMESTAMPTZ.getObjectId(), FORMAT_TEXT, Instant.class))
+                .isEqualTo(instant);
+    }
+
     @Test
     void decodeNoByteBuf() {
         assertThat(new InstantCodec(TEST).decode(null, dataType, FORMAT_TEXT, Instant.class)).isNull();

src/test/java/io/r2dbc/postgresql/codec/LocalDateTimeCodecUnitTests.java

@@ -19,6 +19,7 @@
 import io.r2dbc.postgresql.client.Parameter;
 import org.junit.jupiter.api.Test;
 
+import java.time.Instant;
 import java.time.LocalDateTime;
 
 import static io.r2dbc.postgresql.client.Parameter.NULL_VALUE;
@@ -54,6 +55,16 @@ void decode() {
             .isEqualTo(localDateTime);
     }
 
+    @Test
+    void decodeUTC() {
+        LocalDateTime localDateTime = LocalDateTime.parse("2018-11-05T00:06:31.700426");
+
+        assertThat(new LocalDateTimeCodec(TEST).decode(encode(TEST, "2018-11-05 00:06:31.700426+00:00"), dataType, FORMAT_TEXT, LocalDateTime.class))
+                .isEqualTo(localDateTime);
+        assertThat(new LocalDateTimeCodec(TEST).decode(encode(TEST, "2018-11-05 00:06:31.700426+00"), dataType, FORMAT_TEXT, LocalDateTime.class))
+                .isEqualTo(localDateTime);
+    }
+
     @Test
     void decodeNoByteBuf() {
         assertThat(new LocalDateTimeCodec(TEST).decode(null, dataType, FORMAT_TEXT, LocalDateTime.class)).isNull();

src/test/java/io/r2dbc/postgresql/codec/OffsetDateTimeCodecUnitTests.java

@@ -50,10 +50,22 @@ void constructorNoByteBufAllocator() {
     void decode() {
         OffsetDateTime offsetDateTime = OffsetDateTime.parse("2018-11-05T00:16:00.899797+09:00");
 
+        assertThat(new OffsetDateTimeCodec(TEST).decode(encode(TEST, "2018-11-05 00:16:00.899797+09:00"), dataType, FORMAT_TEXT, OffsetDateTime.class))
+                .isEqualTo(offsetDateTime);
         assertThat(new OffsetDateTimeCodec(TEST).decode(encode(TEST, "2018-11-05 00:16:00.899797+09"), dataType, FORMAT_TEXT, OffsetDateTime.class))
             .isEqualTo(offsetDateTime);
     }
 
+    @Test
+    void decodeUTC() {
+        OffsetDateTime offsetDateTime = OffsetDateTime.parse("2018-11-05T00:16:00.899797+00:00");
+
+        assertThat(new OffsetDateTimeCodec(TEST).decode(encode(TEST, "2018-11-05 00:16:00.899797+00:00"), dataType, FORMAT_TEXT, OffsetDateTime.class))
+                .isEqualTo(offsetDateTime);
+        assertThat(new OffsetDateTimeCodec(TEST).decode(encode(TEST, "2018-11-05 00:16:00.899797+00"), dataType, FORMAT_TEXT, OffsetDateTime.class))
+                .isEqualTo(offsetDateTime);
+    }
+
     @Test
     void decodeNoByteBuf() {
         assertThat(new OffsetDateTimeCodec(TEST).decode(null, dataType, FORMAT_TEXT, OffsetDateTime.class)).isNull();

src/test/java/io/r2dbc/postgresql/codec/ZonedDateTimeCodecUnitTests.java

@@ -50,10 +50,22 @@ void constructorNoByteBufAllocator() {
     void decode() {
         ZonedDateTime zonedDateTime = ZonedDateTime.parse("2018-11-05T00:20:25.039883+09:00[Asia/Tokyo]");
 
+        assertThat(new ZonedDateTimeCodec(TEST).decode(encode(TEST, "2018-11-05 00:20:25.039883+09:00"), dataType, FORMAT_TEXT, ZonedDateTime.class))
+                .isEqualTo(zonedDateTime);
         assertThat(new ZonedDateTimeCodec(TEST).decode(encode(TEST, "2018-11-05 00:20:25.039883+09"), dataType, FORMAT_TEXT, ZonedDateTime.class))
             .isEqualTo(zonedDateTime);
     }
 
+    @Test
+    void decodeUTC() {
+        ZonedDateTime zonedDateTime = ZonedDateTime.parse("2018-11-05T00:20:25.039883+00:00");
+
+        assertThat(new ZonedDateTimeCodec(TEST).decode(encode(TEST, "2018-11-05 00:20:25.039883+00:00"), dataType, FORMAT_TEXT, ZonedDateTime.class))
+                .isEqualTo(zonedDateTime);
+        assertThat(new ZonedDateTimeCodec(TEST).decode(encode(TEST, "2018-11-05 00:20:25.039883+00"), dataType, FORMAT_TEXT, ZonedDateTime.class))
+                .isEqualTo(zonedDateTime);
+    }
+
     @Test
     void decodeNoByteBuf() {
         assertThat(new ZonedDateTimeCodec(TEST).decode(null, dataType, FORMAT_TEXT, ZonedDateTime.class)).isNull();