GCS_MAVLink: mark as not receiving when too many items in MISSION_COUNT.count

peterbarker · peterbarker · commit 90fc0b93faab · 2024-04-15T21:07:54.000+10:00
we left things in the "receiving" state, which would eventually lead to a timeout, rather than just failing instanenously with the correct code.
diff --git a/libraries/GCS_MAVLink/MissionItemProtocol.cpp b/libraries/GCS_MAVLink/MissionItemProtocol.cpp
@@ -73,6 +73,8 @@ void MissionItemProtocol::handle_mission_count(
         // the upload count may have changed; free resources and
         // allocate them again:
         free_upload_resources();
+        receiving = false;
+        link = nullptr;
     }
 
     if (packet.count > max_items()) {

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,8 @@ void MissionItemProtocol::handle_mission_count(`
`73`	`73`	`// the upload count may have changed; free resources and`
`74`	`74`	`// allocate them again:`
`75`	`75`	`free_upload_resources();`
	`76`	`+ receiving = false;`
	`77`	`+ link = nullptr;`
`76`	`78`	`}`
`77`	`79`
`78`	`80`	`if (packet.count > max_items()) {`