Merge pull request #329 from devall-org/cleanup_type_of_class_attrs

Cleanup type of class attrs

Author: mitkins

lib/petal_components/accordion.ex

@@ -3,7 +3,7 @@ defmodule PetalComponents.Accordion do
   alias Phoenix.LiveView.JS
 
   attr(:container_id, :string)
-  attr(:class, :any, default: "", doc: "CSS class for parent container")
+  attr(:class, :any, default: nil, doc: "CSS class for parent container")
   attr(:entries, :list, default: [%{}])
 
   attr(:js_lib, :string,

lib/petal_components/alert.ex

@@ -8,7 +8,7 @@ defmodule PetalComponents.Alert do
   )
 
   attr(:with_icon, :boolean, default: false, doc: "adds some icon base classes")
-  attr(:class, :any, default: "", doc: "CSS class for parent div")
+  attr(:class, :any, default: nil, doc: "CSS class for parent div")
   attr(:heading, :string, default: nil, doc: "label your heading")
   attr(:label, :string, default: nil, doc: "label your alert")
   attr(:rest, :global)

lib/petal_components/avatar.ex

@@ -4,7 +4,7 @@ defmodule PetalComponents.Avatar do
   attr(:src, :string, default: nil, doc: "hosted avatar URL")
   attr(:alt, :string, default: nil, doc: "alt text for avatar image")
   attr(:size, :string, default: "md", values: ["xs", "sm", "md", "lg", "xl"])
-  attr(:class, :string, default: "", doc: "CSS class")
+  attr(:class, :any, default: nil, doc: "CSS class")
   attr(:name, :string, default: nil, doc: "name for placeholder initials")
 
   attr(:random_color, :boolean,
@@ -61,7 +61,7 @@ defmodule PetalComponents.Avatar do
   end
 
   attr(:size, :string, default: "md", values: ["xs", "sm", "md", "lg", "xl"])
-  attr(:class, :string, default: "", doc: "CSS class")
+  attr(:class, :any, default: nil, doc: "CSS class")
   attr(:avatars, :list, default: [], doc: "list of your hosted avatar URLs")
   attr(:rest, :global)
 

lib/petal_components/badge.ex

@@ -11,7 +11,7 @@ defmodule PetalComponents.Badge do
 
   attr(:role, :string, default: "note", values: ["note", "status"])
   attr(:with_icon, :boolean, default: false, doc: "adds some icon base classes")
-  attr(:class, :string, default: "", doc: "CSS class for parent div")
+  attr(:class, :any, default: nil, doc: "CSS class for parent div")
   attr(:label, :string, default: nil, doc: "label your badge")
   attr(:rest, :global)
   slot(:inner_block, required: false)

lib/petal_components/breadcrumbs.ex

@@ -3,9 +3,9 @@ defmodule PetalComponents.Breadcrumbs do
   alias PetalComponents.{Icon, Link}
 
   attr(:separator, :string, default: "slash", values: ["slash", "chevron"])
-  attr(:class, :string, default: "", doc: "Parent div CSS class")
-  attr(:separator_class, :string, default: "", doc: "Separator div CSS class")
-  attr(:link_class, :string, default: "", doc: "Link class CSS")
+  attr(:class, :any, default: nil, doc: "Parent div CSS class")
+  attr(:separator_class, :any, default: nil, doc: "Separator div CSS class")
+  attr(:link_class, :any, default: nil, doc: "Link class CSS")
   attr(:links, :list, default: [], doc: "List of your links")
   attr(:aria_label, :string, default: "Breadcrumbs", doc: "ARIA label for the nav")
   attr(:rest, :global)

lib/petal_components/button.ex

@@ -41,7 +41,7 @@ defmodule PetalComponents.Button do
     default: "button",
     values: ["a", "live_patch", "live_redirect", "button"]
 
-  attr :class, :string, default: "", doc: "CSS class"
+  attr :class, :any, default: nil, doc: "CSS class"
   attr :label, :string, default: nil, doc: "labels your button"
 
   attr :rest, :global,
@@ -92,7 +92,7 @@ defmodule PetalComponents.Button do
     default: "button",
     values: ["a", "live_patch", "live_redirect", "button"]
 
-  attr :class, :string, default: "", doc: "CSS class"
+  attr :class, :any, default: nil, doc: "CSS class"
   attr :tooltip, :string, default: nil, doc: "tooltip text"
 
   attr :rest, :global,

lib/petal_components/card.ex

@@ -1,7 +1,7 @@
 defmodule PetalComponents.Card do
   use Phoenix.Component
 
-  attr(:class, :string, default: "", doc: "CSS class")
+  attr(:class, :any, default: nil, doc: "CSS class")
   attr(:variant, :string, default: "basic", values: ["basic", "outline"])
   attr(:rest, :global)
   slot(:inner_block, required: false)
@@ -16,9 +16,9 @@ defmodule PetalComponents.Card do
     """
   end
 
-  attr(:aspect_ratio_class, :string, default: "aspect-video", doc: "aspect ratio class")
+  attr(:aspect_ratio_class, :any, default: "aspect-video", doc: "aspect ratio class")
   attr(:src, :string, default: nil, doc: "hosted image URL")
-  attr(:class, :string, default: "", doc: "CSS class")
+  attr(:class, :any, default: nil, doc: "CSS class")
   attr(:rest, :global)
   slot(:inner_block, required: false)
 
@@ -35,12 +35,12 @@ defmodule PetalComponents.Card do
   attr(:heading, :string, default: nil, doc: "creates a heading")
   attr(:category, :string, default: nil, doc: "creates a category")
 
-  attr(:category_color_class, :string,
+  attr(:category_color_class, :any,
     default: "pc-card__category--primary",
     doc: "sets a category color class"
   )
 
-  attr(:class, :string, default: "", doc: "CSS class")
+  attr(:class, :any, default: nil, doc: "CSS class")
   attr(:rest, :global)
   slot(:inner_block, required: false)
 
@@ -60,7 +60,7 @@ defmodule PetalComponents.Card do
     """
   end
 
-  attr(:class, :string, default: "", doc: "CSS class")
+  attr(:class, :any, default: nil, doc: "CSS class")
   attr(:rest, :global)
   slot(:inner_block, required: false)
 

lib/petal_components/container.ex

@@ -7,7 +7,7 @@ defmodule PetalComponents.Container do
     doc: "sets container max-width"
   )
 
-  attr(:class, :string, default: "", doc: "CSS class for container")
+  attr(:class, :any, default: nil, doc: "CSS class for container")
   attr(:no_padding_on_mobile, :boolean, default: false, doc: "specify for padding on mobile")
   attr(:rest, :global)
   slot(:inner_block, required: false)

lib/petal_components/dropdown.ex

@@ -13,10 +13,10 @@ defmodule PetalComponents.Dropdown do
 
   attr :options_container_id, :string
   attr :label, :string, default: nil, doc: "labels your dropdown option"
-  attr :class, :string, default: "", doc: "any extra CSS class for the parent container"
+  attr :class, :any, default: nil, doc: "any extra CSS class for the parent container"
 
-  attr :menu_items_wrapper_class, :string,
-    default: "",
+  attr :menu_items_wrapper_class, :any,
+    default: nil,
     doc: "any extra CSS class for menu item wrapper container"
 
   attr :js_lib, :string,
@@ -78,7 +78,11 @@ defmodule PetalComponents.Dropdown do
       </div>
       <div
         {js_attributes("options_container", @js_lib, @options_container_id)}
-        class={"#{placement_class(@placement)} #{@menu_items_wrapper_class} pc-dropdown__menu-items-wrapper"}
+        class={[
+          placement_class(@placement),
+          @menu_items_wrapper_class,
+          "pc-dropdown__menu-items-wrapper"
+        ]}
         role="menu"
         id={@options_container_id}
         aria-orientation="vertical"
@@ -94,7 +98,7 @@ defmodule PetalComponents.Dropdown do
 
   attr :to, :string, default: nil, doc: "link path"
   attr :label, :string, doc: "link label"
-  attr :class, :string, default: "", doc: "any additional CSS classes"
+  attr :class, :any, default: nil, doc: "any additional CSS classes"
   attr :disabled, :boolean, default: false
 
   attr :link_type, :string,

lib/petal_components/field.ex

@@ -61,10 +61,10 @@ defmodule PetalComponents.Field do
 
   attr :rows, :string, default: "4", doc: "rows for textarea"
 
-  attr :class, :string, default: nil, doc: "the class to add to the input"
-  attr :wrapper_class, :string, default: nil, doc: "the wrapper div classes"
+  attr :class, :any, default: nil, doc: "the class to add to the input"
+  attr :wrapper_class, :any, default: nil, doc: "the wrapper div classes"
   attr :help_text, :string, default: nil, doc: "context/help for your field"
-  attr :label_class, :string, default: nil, doc: "extra CSS for your label"
+  attr :label_class, :any, default: nil, doc: "extra CSS for your label"
   attr :selected, :any, default: nil, doc: "the selected value for select inputs"
 
   attr :required, :boolean,
@@ -333,7 +333,7 @@ defmodule PetalComponents.Field do
     """
   end
 
-  attr :class, :string, default: nil
+  attr :class, :any, default: nil
   attr :errors, :list, default: []
   attr :name, :string
   attr :rest, :global
@@ -359,7 +359,7 @@ defmodule PetalComponents.Field do
   Renders a label.
   """
   attr :for, :string, default: nil
-  attr :class, :string, default: nil
+  attr :class, :any, default: nil
   attr :rest, :global
   attr :required, :boolean, default: false
   slot :inner_block, required: true
@@ -385,7 +385,7 @@ defmodule PetalComponents.Field do
     """
   end
 
-  attr :class, :string, default: "", doc: "extra classes for the help text"
+  attr :class, :any, default: nil, doc: "extra classes for the help text"
   attr :help_text, :string, default: nil, doc: "context/help for your field"
   slot :inner_block, required: false
   attr :rest, :global