Phobos instrumentation settings for actor props get overwritten by PhobosActorCell settings

[object]

I continue struggling with custom actor type name, and I believe this time I hit an issue that may be unrelated to F#.

I debug the code that creates an instance of an actor by calling ActorOf on an actor factory. If I debug the code, I reach the following Phobos code:

public override IActorRef ActorOf(Props props, string name = null)
{
return base.ActorOf(this.InstrumentationSettings.PropagateSettingsToChildren ? props.WithInstrumentation(this.InstrumentationSettings) : props, name);
}

The custom actor type name is inside "props" data that are sent to the method ActorOf. But the flag PropagateSettingsToChildren on the instance of PhobosActorCell is set to "true", so instead of using the "props" data that are sent to the method it uses data that belong to this.InstrumentationSettings, and there ActorTypeName is set to "null". So whatever I send gets overwritten by the InstrumentationSettings of the PhobosActorCell.

I never set the flag PropagateSettingsToChildren.

So how should I trigger usage of setting from my props, and not the PhobosActorCell?

[Aaronontheweb]

On it - not sure if this will make it into v2.7.1 (since that's needed urgently per akkadotnet/akka.net#7467 ) but we were already planning on doing a 2.7.2 release shortly thereafter. I'll see if I can include this in 2.7.2.

[Aaronontheweb]

Have this issue fixed in a PR, along with some convenience methods that make it somewhat easier to configure too. Letting CI/CD do it's thing and then I'll try to get a release prepared this evening.

[object]

Is there anything changed on a client side to configure instrumentation?

[Aaronontheweb]

@object I've added a convenience method that makes it easier to specify a custom actor name:

// where Sys == ActorSystem
Props.Create(() => new EntityActor(magicString))
                        .WithInstrumentation(Sys, settings => settings.WithActorTypeName("Foober")

But other than that - no! Everything still works the same. And I added a reproduction spec to make sure this works with Cluster.Sharding too. I'm typing up the Phobos 2.8.0 release notes now and I'll push this to Sdkbin shortly.

[object]

Great! I'll try it tomorrow.