Skip to content

Commit 648b08d

Browse files
PulsePoint Bid Adapter: support for additional user id providers (prebid#7389)
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per prebid#509 * ET-1765: Adding support for additional params in PulsePoint adapter (#2) * ET-1850: Fixing prebid#866 * Minor fix * Adding mandatory parameters to Bid * ET-9372: PulsePoint Adapter - support for additional user id providers * Fix for haloId
1 parent c064ea9 commit 648b08d

File tree

2 files changed

+30
-8
lines changed

2 files changed

+30
-8
lines changed

modules/pulsepointBidAdapter.js

+9-3
Original file line numberDiff line numberDiff line change
@@ -421,12 +421,18 @@ function user(bidRequest, bidderRequest) {
421421
if (bidRequest) {
422422
if (bidRequest.userId) {
423423
ext.eids = [];
424-
addExternalUserId(ext.eids, bidRequest.userId.pubcid, 'pubcommon');
424+
addExternalUserId(ext.eids, bidRequest.userId.pubcid, 'pubcid.org');
425425
addExternalUserId(ext.eids, bidRequest.userId.britepoolid, 'britepool.com');
426-
addExternalUserId(ext.eids, bidRequest.userId.criteoId, 'criteo');
427-
addExternalUserId(ext.eids, bidRequest.userId.idl_env, 'identityLink');
426+
addExternalUserId(ext.eids, bidRequest.userId.criteoId, 'criteo.com');
427+
addExternalUserId(ext.eids, bidRequest.userId.idl_env, 'liveramp.com');
428428
addExternalUserId(ext.eids, utils.deepAccess(bidRequest, 'userId.id5id.uid'), 'id5-sync.com', utils.deepAccess(bidRequest, 'userId.id5id.ext'));
429429
addExternalUserId(ext.eids, utils.deepAccess(bidRequest, 'userId.parrableId.eid'), 'parrable.com');
430+
addExternalUserId(ext.eids, bidRequest.userId.fabrickId, 'neustar.biz');
431+
addExternalUserId(ext.eids, utils.deepAccess(bidRequest, 'userId.haloId.haloId'), 'audigent.com');
432+
addExternalUserId(ext.eids, bidRequest.userId.merkleId, 'merkleinc.com');
433+
addExternalUserId(ext.eids, bidRequest.userId.lotamePanoramaId, 'crwdcntrl.net');
434+
addExternalUserId(ext.eids, bidRequest.userId.connectid, 'verizonmedia.com');
435+
addExternalUserId(ext.eids, utils.deepAccess(bidRequest, 'userId.uid2.id'), 'uidapi.com');
430436
// liveintent
431437
if (bidRequest.userId.lipb && bidRequest.userId.lipb.lipbid) {
432438
addExternalUserId(ext.eids, bidRequest.userId.lipb.lipbid, 'liveintent.com');

test/spec/modules/pulsepointBidAdapter_spec.js

+21-5
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,7 @@ describe('PulsePoint Adapter Tests', function () {
637637
expect(ortbRequest.user.ext).to.not.be.undefined;
638638
expect(ortbRequest.user.ext.eids).to.not.be.undefined;
639639
expect(ortbRequest.user.ext.eids).to.have.lengthOf(2);
640-
expect(ortbRequest.user.ext.eids[0].source).to.equal('pubcommon');
640+
expect(ortbRequest.user.ext.eids[0].source).to.equal('pubcid.org');
641641
expect(ortbRequest.user.ext.eids[0].uids).to.have.lengthOf(1);
642642
expect(ortbRequest.user.ext.eids[0].uids[0].id).to.equal('userid_pubcid');
643643
expect(ortbRequest.user.ext.eids[1].source).to.equal('adserver.org');
@@ -659,6 +659,16 @@ describe('PulsePoint Adapter Tests', function () {
659659
parrableId: { eid: 'parrable_id234' },
660660
lipb: {
661661
lipbid: 'liveintent_id123'
662+
},
663+
haloId: {
664+
haloId: 'halo_user1'
665+
},
666+
lotamePanoramaId: 'lotame_user2',
667+
merkleId: 'merkle_user3',
668+
fabrickId: 'fabrick_user4',
669+
connectid: 'connect_user5',
670+
uid2: {
671+
id: 'uid2_user6'
662672
}
663673
};
664674
const userVerify = function(obj, source, id) {
@@ -677,13 +687,19 @@ describe('PulsePoint Adapter Tests', function () {
677687
expect(ortbRequest.user).to.not.be.undefined;
678688
expect(ortbRequest.user.ext).to.not.be.undefined;
679689
expect(ortbRequest.user.ext.eids).to.not.be.undefined;
680-
expect(ortbRequest.user.ext.eids).to.have.lengthOf(6);
690+
expect(ortbRequest.user.ext.eids).to.have.lengthOf(12);
681691
userVerify(ortbRequest.user.ext.eids[0], 'britepool.com', 'britepool_id123');
682-
userVerify(ortbRequest.user.ext.eids[1], 'criteo', 'criteo_id234');
683-
userVerify(ortbRequest.user.ext.eids[2], 'identityLink', 'idl_id123');
692+
userVerify(ortbRequest.user.ext.eids[1], 'criteo.com', 'criteo_id234');
693+
userVerify(ortbRequest.user.ext.eids[2], 'liveramp.com', 'idl_id123');
684694
userVerify(ortbRequest.user.ext.eids[3], 'id5-sync.com', 'id5id_234');
685695
userVerify(ortbRequest.user.ext.eids[4], 'parrable.com', 'parrable_id234');
686-
userVerify(ortbRequest.user.ext.eids[5], 'liveintent.com', 'liveintent_id123');
696+
userVerify(ortbRequest.user.ext.eids[5], 'neustar.biz', 'fabrick_user4');
697+
userVerify(ortbRequest.user.ext.eids[6], 'audigent.com', 'halo_user1');
698+
userVerify(ortbRequest.user.ext.eids[7], 'merkleinc.com', 'merkle_user3');
699+
userVerify(ortbRequest.user.ext.eids[8], 'crwdcntrl.net', 'lotame_user2');
700+
userVerify(ortbRequest.user.ext.eids[9], 'verizonmedia.com', 'connect_user5');
701+
userVerify(ortbRequest.user.ext.eids[10], 'uidapi.com', 'uid2_user6');
702+
userVerify(ortbRequest.user.ext.eids[11], 'liveintent.com', 'liveintent_id123');
687703
});
688704
it('Verify multiple adsizes', function () {
689705
const bidRequests = deepClone(slotConfigs);

0 commit comments

Comments
 (0)