Skip to content

Commit 0ba84b6

Browse files
Bill Newmanvladis-teqblazeAiholkinMykhailo Yaremchuk
authored
Colossus Bid Adapter: update bid params (prebid#7907)
* add video&native traffic colossus ssp * Native obj validation * Native obj validation #2 * Added size field in requests * fixed test * fix merge conflicts * move to 3.0 * move to 3.0 * fix IE11 new URL issue * fix IE11 new URL issue * fix IE11 new URL issue * https for 3.0 * add https test * add ccp and schain features * fix test * sync with upstream, fix conflicts * Update colossussspBidAdapter.js remove commented code * Update colossussspBidAdapter.js lint fix * identity extensions * identity extensions * fix * fix * fix * fix * fix * add tests for user ids * fix * fix * fix * fix * fix * fix * fix * add gdpr support * add gdpr support * id5id support * Update colossussspBidAdapter.js add bidfloor parameter * Update colossussspBidAdapter.js check bidfloor * Update colossussspBidAdapter.js * Update colossussspBidAdapter.js * Update colossussspBidAdapter.js * Update colossussspBidAdapter_spec.js * use floor module * Revert "use floor module" This reverts commit f0c5c24. * use floor module * update to 5v * fix * add uid2 and bidFloor support * fix * add pbadslot support * fix conflicts * add onBidWon * refactor * add test for onBidWon() * fix * add group_id * Trigger circleci Co-authored-by: Vladislav Isaiko <[email protected]> Co-authored-by: Aiholkin <[email protected]> Co-authored-by: Mykhailo Yaremchuk <[email protected]>
1 parent 30c6f40 commit 0ba84b6

File tree

3 files changed

+27
-10
lines changed

3 files changed

+27
-10
lines changed

modules/colossussspBidAdapter.js

+8-7
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,13 @@ export const spec = {
6161
const location = winTop.location;
6262
let placements = [];
6363
let request = {
64-
'deviceWidth': winTop.screen.width,
65-
'deviceHeight': winTop.screen.height,
66-
'language': (navigator && navigator.language) ? navigator.language : '',
67-
'secure': location.protocol === 'https:' ? 1 : 0,
68-
'host': location.host,
69-
'page': location.pathname,
70-
'placements': placements,
64+
deviceWidth: winTop.screen.width,
65+
deviceHeight: winTop.screen.height,
66+
language: (navigator && navigator.language) ? navigator.language : '',
67+
secure: location.protocol === 'https:' ? 1 : 0,
68+
host: location.host,
69+
page: location.pathname,
70+
placements: placements,
7171
};
7272

7373
if (bidderRequest) {
@@ -85,6 +85,7 @@ export const spec = {
8585
let traff = bid.params.traffic || BANNER
8686
let placement = {
8787
placementId: bid.params.placement_id,
88+
groupId: bid.params.group_id,
8889
bidId: bid.bidId,
8990
sizes: bid.mediaTypes[traff].sizes,
9091
traffic: traff,

modules/colossussspBidAdapter.md

+15-1
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,19 @@ Module that connects to Colossus SSP demand sources
2626
traffic: 'banner'
2727
}
2828
}]
29-
];
29+
}, {
30+
code: 'placementid_1',
31+
mediaTypes: {
32+
banner: {
33+
sizes: [[300, 250], [300,600]]
34+
}
35+
},
36+
bids: [{
37+
bidder: 'colossusssp',
38+
params: {
39+
group_id: 0,
40+
traffic: 'banner'
41+
}
42+
}]
43+
}];
3044
```

test/spec/modules/colossussspBidAdapter_spec.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ describe('ColossussspAdapter', function () {
77
bidder: 'colossusssp',
88
bidderRequestId: '145e1d6a7837c9',
99
params: {
10-
placement_id: 0
10+
placement_id: 0,
11+
group_id: 0
1112
},
1213
placementCode: 'placementid_0',
1314
auctionId: '74f78609-a92d-4cf1-869f-1b244bbfb5d2',
@@ -95,9 +96,10 @@ describe('ColossussspAdapter', function () {
9596
let placements = data['placements'];
9697
for (let i = 0; i < placements.length; i++) {
9798
let placement = placements[i];
98-
expect(placement).to.have.all.keys('placementId', 'eids', 'bidId', 'traffic', 'sizes', 'schain', 'floor', 'gpid');
99+
expect(placement).to.have.all.keys('placementId', 'groupId', 'eids', 'bidId', 'traffic', 'sizes', 'schain', 'floor', 'gpid');
99100
expect(placement.schain).to.be.an('object')
100101
expect(placement.placementId).to.be.a('number');
102+
expect(placement.groupId).to.be.a('number');
101103
expect(placement.bidId).to.be.a('string');
102104
expect(placement.traffic).to.be.a('string');
103105
expect(placement.sizes).to.be.an('array');

0 commit comments

Comments
 (0)