Skip to content

Commit af91070

Browse files
LemonInTheDarkmanofpepsi
authored andcommitted
516 Compile Compatibility (#88611)
Renames all uses of caller, as they (currently) shadow the new byond var and will in future error Ups our "wan if compiled after" experiement compile version to 516 Adds an alternate 516 unit test
1 parent 93f4a34 commit af91070

File tree

7 files changed

+6
-6
lines changed

7 files changed

+6
-6
lines changed

.github/alternate_byond_versions.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
# This is useful for making sure we maintain compatibility with both older and newer versions,
33
# while still having our main tests run on a guaranteed pinned version.
44

5-
# Format is version: map
65
# Format is "version: map" or "version: map;max_required_client_version"
76
# Example:
87
# 500.1337: runtimestation

code/_experiments.dm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,5 @@
1818
#endif
1919

2020
#if DM_VERSION >= 517
21-
#error "Remove all 517 experiments"
21+
#error "Remove all 516 experiments"
2222
#endif

code/datums/actions/cooldown_action.dm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@
263263
if(unset_after_click)
264264
unset_click_ability(clicker, refund_cooldown = FALSE)
265265
clicker.next_click = world.time + click_cd_override
266+
266267
return TRUE
267268

268269
/// For signal calling

code/datums/components/pet_commands/pet_command.dm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@
8383
if (!found_new_target)
8484
return
8585

86-
if (try_activate_command(speaker))
86+
if (try_activate_command(commander = speaker, radial_command = FALSE))
8787
look_for_target(parent, target)
8888

8989
/// Does this callout with this target trigger this command?

code/game/machinery/dna_infuser/infuser_actions.dm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
ink.firer = clicker
5555
ink.fire()
5656
playsound(clicker, 'sound/items/weapons/pierce.ogg', 20, TRUE, -1)
57-
clicker.newtonian_move(get_dir(target, clicker))
57+
clicker.newtonian_move(get_angle(target, clicker))
5858
StartCooldown()
5959
return TRUE
6060

code/modules/mob/living/carbon/alien/adult/alien_powers.dm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ Doesn't work on other aliens/AI.*/
298298
neurotoxin.aim_projectile(target, clicker, modifiers)
299299
neurotoxin.firer = clicker
300300
neurotoxin.fire()
301-
clicker.newtonian_move(get_dir(target, clicker))
301+
clicker.newtonian_move(get_angle(target, clicker))
302302
return TRUE
303303

304304
// Has to return TRUE, otherwise is skipped.

code/modules/spells/spell_types/pointed/swap.dm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
/datum/action/cooldown/spell/pointed/swap/InterceptClickOn(mob/living/clicker, params, atom/target)
3939
if(!LAZYACCESS(params2list(params), RIGHT_CLICK))
4040
return ..()
41-
41+
4242
if(!IsAvailable(feedback = TRUE))
4343
return FALSE
4444
if(!target)

0 commit comments

Comments
 (0)