Don't call size() unless needed for debugging

pcc · pcc · commit baecbc474d24 · 2024-11-26T18:45:53.000-08:00
diff --git a/simd/ninja-simd.cpp b/simd/ninja-simd.cpp
@@ -784,8 +784,9 @@ void print_difference(timespec a, timespec b) {
           ((a64 - b64) % 1000000000) / 1000);
 }
 
+static bool debug_enabled = getenv("POM_DEBUG");
+
 void dbg(const char* format, ...) {
-  static bool debug_enabled = getenv("POM_DEBUG");
   if (!debug_enabled)
     return;
   print_difference(now(), prog_begin);
@@ -1900,7 +1901,8 @@ void parse(Global& global, std::string_view path,
   }
   parse_scope(tg, global, nullptr, path);
   tg.wait();
-  dbg("%zu nodes\n", global.nodes.size());
+  if (debug_enabled)
+    dbg("%zu nodes\n", global.nodes.size());
 }
 
 void print_command(Edge* e) {

Original file line number	Diff line number	Diff line change
`@@ -784,8 +784,9 @@ void print_difference(timespec a, timespec b) {`
`784`	`784`	`((a64 - b64) % 1000000000) / 1000);`
`785`	`785`	`}`
`786`	`786`
	`787`	`+static bool debug_enabled = getenv("POM_DEBUG");`
	`788`	`+`
`787`	`789`	`void dbg(const char* format, ...) {`
`788`		`- static bool debug_enabled = getenv("POM_DEBUG");`
`789`	`790`	`if (!debug_enabled)`
`790`	`791`	`return;`
`791`	`792`	`print_difference(now(), prog_begin);`
`@@ -1900,7 +1901,8 @@ void parse(Global& global, std::string_view path,`
`1900`	`1901`	`}`
`1901`	`1902`	`parse_scope(tg, global, nullptr, path);`
`1902`	`1903`	`tg.wait();`
`1903`		`- dbg("%zu nodes\n", global.nodes.size());`
	`1904`	`+ if (debug_enabled)`
	`1905`	`+ dbg("%zu nodes\n", global.nodes.size());`
`1904`	`1906`	`}`
`1905`	`1907`
`1906`	`1908`	`void print_command(Edge* e) {`