Patch only (#422)

* Send patched fields only in patch payload

* Add tests

Author: minottic

scilog/src/app/logbook/core/add-content/add-content.component.spec.ts

@@ -136,11 +136,13 @@ describe('AddContentComponent', () => {
     component.editor = jasmine.createSpyObj("component.editor", ["getData"])
     component.notification.snippetType = 'edit';
     component.contentChanged = true;
+    const sendEditMessageSpy = spyOn<any>(component, 'sendEditMessage');
     const setFromLocalStorageSpy = spyOn<any>(component, 'setFromLocalStorage');
     component.addContent("");
     expect(component.editor.getData).toHaveBeenCalled();
     expect(component.notification.snippetType).toEqual('paragraph');
     expect(setFromLocalStorageSpy).toHaveBeenCalledTimes(0);
+    expect(sendEditMessageSpy).toHaveBeenCalledTimes(0);
   });
 
   it('should prepare quote', () => {
@@ -381,6 +383,19 @@ describe('AddContentComponent', () => {
     expect(localStorageSpy).toHaveBeenCalledOnceWith('123_message', 'edit');
   });
 
+  it('should test sendEditMessage', () => {
+    component.notification = notificationMock;
+    component.data = 'abc';
+    const sendMessageSpy = spyOn(component, 'sendMessage');
+    component['sendEditMessage']();
+    expect(sendMessageSpy).toHaveBeenCalledOnceWith({
+      textcontent: 'abc',
+      id: '6061d9a13587f37b851694d5',
+      linkType: 'paragraph',
+      files: [],
+    });
+  });
+
   function combineHtmlFigureHash(figureMock: string[], hash: string) {
     return (figureMock[0] + ' title="' + hash + '"' + figureMock[1]);
   }

scilog/src/app/logbook/core/add-content/add-content.component.ts

@@ -166,10 +166,18 @@ export class AddContentComponent implements OnInit {
       this.notification.snippetType = 'paragraph';
     localStorage.removeItem(`${this.message?.id}_message`);
     localStorage.removeItem(`${this.message?.id}_tags`);
+    if (this.dialogTitle === 'Modify data snippet')
+      return this.sendEditMessage();
     this.prepareMessage(this.data);
     this.sendMessage();
   };
 
+  private sendEditMessage() {
+    const notification = extractNotificationMessage(this.data, this.message?.files ? this.message.files : []);
+    notification.id = this.notification.id;
+    this.sendMessage(notification);
+  }
+
   onChange({ editor }: ChangeEvent) {
     localStorage.setItem(`${this.message.id}_message`, editor.getData());
     this.contentChanged = true;
@@ -224,9 +232,9 @@ export class AddContentComponent implements OnInit {
     }
   }
 
-  sendMessage() {
+  sendMessage(message: ChangeStreamNotification = undefined) {
     console.log(this.notification);
-    this.dataService.changeMessage(this.notification);
+    this.dataService.changeMessage(message ?? this.notification);
   }
 
   adjustContentForEditor() {

scilog/src/app/logbook/widgets/logbook-item/logbook-item.component.spec.ts

@@ -471,8 +471,6 @@ describe('LogbookItemComponent', () => {
 
     let res = component._preparePatchPayload(referenceEntry, msg);
     // I guess it should only take these variables if they are not defined in the msg...
-    expect(res.accessGroups).toEqual(referenceEntry.accessGroups);
-    expect(res.ownerGroup).toEqual(referenceEntry.ownerGroup);
     expect(res.isPrivate).toEqual(referenceEntry.isPrivate);
     expect(res.tags).toEqual(msg.tags);
     expect(res.files).toEqual([]);

scilog/src/app/logbook/widgets/logbook-item/logbook-item.component.ts

@@ -474,13 +474,9 @@ export class LogbookItemComponent implements OnInit {
     // in the future, this should be extended to support inserting snippets below/above other snippets
     // for now, I just take the last array entry
     let referenceEntry: ChangeStreamNotification = {};
-    // if (this.childSnippets.toArray().length == 0) {
     referenceEntry.ownerGroup = this.logbookInfo.logbookInfo.ownerGroup;
     referenceEntry.accessGroups = this.logbookInfo.logbookInfo.accessGroups;
     referenceEntry.isPrivate = this.logbookInfo.logbookInfo.isPrivate;
-    // } else {
-    //   referenceEntry = this.childSnippets.toArray()[this.childSnippets.toArray().length - 1].snippet;
-    // }
     if (msg.snippetType === "edit") {
     // POST -- EDIT SNIPPET
       let payload: ChangeStreamNotification = this._prepareEditPostPayload(referenceEntry, msg);
@@ -513,8 +509,6 @@ export class LogbookItemComponent implements OnInit {
     // I guess it should only take these variables if they are not defined in the msg...
     console.log("referenceEntry: ", referenceEntry)
     let payload: ChangeStreamNotification = {
-      ownerGroup: referenceEntry.ownerGroup,
-      accessGroups: referenceEntry.accessGroups,
       isPrivate: referenceEntry.isPrivate,
       tags: msg.tags,
       snippetType: "paragraph",