Skip to content

Commit 2a70043

Browse files
authored
chore(DataList): update tests (#9672)
* add spread prop test, update test * chore(DataList): update tests * fix merge error * break out into separate files, pr feedback * updates * fix some example ids * minor test updates * revert action change
1 parent 4f123b1 commit 2a70043

21 files changed

+713
-634
lines changed

packages/react-core/src/components/DataList/DataList.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ class DataList extends React.Component<DataListProps> {
7373
const {
7474
className,
7575
children,
76+
'aria-label': ariaLabel,
7677
onSelectDataListItem,
7778
selectedDataListItemId,
7879
isCompact,
@@ -106,6 +107,7 @@ class DataList extends React.Component<DataListProps> {
106107
)}
107108
style={props.style}
108109
role="list"
110+
aria-label={ariaLabel}
109111
{...props}
110112
ref={this.ref}
111113
>

packages/react-core/src/components/DataList/DataListAction.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ export const DataListAction: React.FunctionComponent<DataListActionProps> = ({
3535
id,
3636
'aria-label': ariaLabel,
3737
'aria-labelledby': ariaLabelledBy,
38+
/* eslint-disable @typescript-eslint/no-unused-vars */
3839
isPlainButtonAction,
39-
/* eslint-enable @typescript-eslint/no-unused-vars */
4040
...props
4141
}: DataListActionProps) => (
4242
<div className={css(styles.dataListItemAction, formatBreakpointMods(visibility, styles), className)} {...props}>

0 commit comments

Comments
 (0)