Forbid to create booking options for past events, require at least one booking option to view groups

Author: patrickrobrecht

app/Policies/BookingOptionPolicy.php

@@ -91,7 +91,13 @@ public function book(?User $user, BookingOption $bookingOption): Response
      */
     public function create(User $user, Event $event): Response
     {
-        if (isset($event->parentEvent)) {
+        if (
+            // Don't create booking options for child events.
+            isset($event->parentEvent)
+            // Don't create booking options for past events.
+            || (isset($event->finished_at) && $event->finished_at->isPast())
+            || (isset($event->started_at) && !isset($event->finished_at) && $event->started_at->isPast())
+        ) {
             return $this->deny();
         }
 

app/Policies/EventPolicy.php

@@ -37,6 +37,10 @@ public function view(?User $user, Event $event): Response
 
     public function viewGroups(User $user, Event $event): Response
     {
+        if ($event->getBookingOptions()->isEmpty()) {
+            return $this->deny();
+        }
+
         return $this->requireAbility($user, Ability::ViewBookingsOfEvent);
     }