update naming of 'WITH' planner flag and fn

Author: alancai98

partiql-planner/api/partiql-planner.api

@@ -29,8 +29,8 @@ public final class org/partiql/planner/builder/PartiQLPlannerBuilder {
 	public final fun addPass (Lorg/partiql/planner/PartiQLPlannerPass;)Lorg/partiql/planner/builder/PartiQLPlannerBuilder;
 	public final fun addPasses ([Lorg/partiql/planner/PartiQLPlannerPass;)Lorg/partiql/planner/builder/PartiQLPlannerBuilder;
 	public final fun build ()Lorg/partiql/planner/PartiQLPlanner;
-	public final fun replaceWithReferences (Z)Lorg/partiql/planner/builder/PartiQLPlannerBuilder;
-	public static synthetic fun replaceWithReferences$default (Lorg/partiql/planner/builder/PartiQLPlannerBuilder;ZILjava/lang/Object;)Lorg/partiql/planner/builder/PartiQLPlannerBuilder;
+	public final fun forceInlineWithClause (Z)Lorg/partiql/planner/builder/PartiQLPlannerBuilder;
+	public static synthetic fun forceInlineWithClause$default (Lorg/partiql/planner/builder/PartiQLPlannerBuilder;ZILjava/lang/Object;)Lorg/partiql/planner/builder/PartiQLPlannerBuilder;
 	public final fun signal (Z)Lorg/partiql/planner/builder/PartiQLPlannerBuilder;
 	public static synthetic fun signal$default (Lorg/partiql/planner/builder/PartiQLPlannerBuilder;ZILjava/lang/Object;)Lorg/partiql/planner/builder/PartiQLPlannerBuilder;
 }

partiql-planner/src/main/kotlin/org/partiql/planner/builder/PartiQLPlannerBuilder.kt

@@ -18,7 +18,7 @@ import org.partiql.planner.internal.SqlPlanner
  */
 public class PartiQLPlannerBuilder {
 
-    private val flags: MutableSet<PlannerFlag> = mutableSetOf(PlannerFlag.REPLACE_WITH_REFS)
+    private val flags: MutableSet<PlannerFlag> = mutableSetOf(PlannerFlag.FORCE_INLINE_WITH_CLAUSE)
     private val passes: MutableList<PartiQLPlannerPass> = mutableListOf()
 
     /**
@@ -70,11 +70,11 @@ public class PartiQLPlannerBuilder {
      * @param replaceWith denotes whether to replace WITH variable references with their definitions.
      * @return
      */
-    public fun replaceWithReferences(replaceWith: Boolean = true): PartiQLPlannerBuilder {
+    public fun forceInlineWithClause(replaceWith: Boolean = true): PartiQLPlannerBuilder {
         if (replaceWith) {
-            flags.add(PlannerFlag.REPLACE_WITH_REFS)
+            flags.add(PlannerFlag.FORCE_INLINE_WITH_CLAUSE)
         } else {
-            flags.remove(PlannerFlag.REPLACE_WITH_REFS)
+            flags.remove(PlannerFlag.FORCE_INLINE_WITH_CLAUSE)
         }
         return this
     }

partiql-planner/src/main/kotlin/org/partiql/planner/internal/PlannerFlag.kt

@@ -22,5 +22,5 @@ internal enum class PlannerFlag {
      * Experimental flag to enable planner to replace references to WITH variables with their definitions.
      * By default, this flag is included in the default planner phase.
      */
-    REPLACE_WITH_REFS
+    FORCE_INLINE_WITH_CLAUSE
 }

partiql-planner/src/main/kotlin/org/partiql/planner/internal/typer/PlanTyper.kt

@@ -295,7 +295,7 @@ internal class PlanTyper(private val env: Env, config: Context, private val flag
                 element.copy(representation = representation)
             }
             // Include the WITH elements iff the `flags` contains the `REPLACE_WITH_REFS` planner flag.
-            val rewriteWith = flags.contains(PlannerFlag.REPLACE_WITH_REFS)
+            val rewriteWith = flags.contains(PlannerFlag.FORCE_INLINE_WITH_CLAUSE)
             val withElements = if (rewriteWith) {
                 elements
             } else {

partiql-planner/src/test/kotlin/org/partiql/planner/internal/typer/PlanTyperTest.kt

@@ -129,7 +129,7 @@ class PlanTyperTest {
                     .build(),
                 config.errorListener
             )
-            return PlanTyperWrapper(PlanTyper(env, config, setOf(PlannerFlag.REPLACE_WITH_REFS)))
+            return PlanTyperWrapper(PlanTyper(env, config, setOf(PlannerFlag.FORCE_INLINE_WITH_CLAUSE)))
         }
     }