Clean up ExprFunction tests

Author: lziq

lang/src/org/partiql/lang/eval/Exceptions.kt

@@ -52,6 +52,16 @@ internal fun errNoContext(message: String, errorCode: ErrorCode, internal: Boole
 internal fun err(message: String, errorCode: ErrorCode, errorContext: PropertyValueMap?, internal: Boolean): Nothing =
     throw EvaluationException(message, errorCode, errorContext, internal = internal)
 
+internal fun expectedArgTypeErrorMsg (types: List<ExprValueType>) : String = when (types.size) {
+    0 -> throw IllegalStateException("Should have at least one expected argument type. ")
+    1 -> types[0].toString()
+    else -> {
+        val window = types.size - 1
+        val (most, last) = types.windowed(window, window, true)
+        most.joinToString(", ") + ", or ${last.first()}"
+    }
+}
+
 /** Throw an [ErrorCode.EVALUATOR_INCORRECT_TYPE_OF_ARGUMENTS_TO_FUNC_CALL] error */
 internal fun errInvalidArgumentType(
     signature: FunctionSignature,
@@ -62,14 +72,7 @@ internal fun errInvalidArgumentType(
 ): Nothing {
     val arity = signature.arity
 
-    val expectedTypeMsg = when(expectedTypes.size) {
-        1 -> expectedTypes[0]
-        else -> {
-            val window = expectedTypes.size - 1
-            val (most, last) = expectedTypes.windowed(window, window, true)
-            most.joinToString(", ") + ", or ${last.first()}"
-        }
-    }
+    val expectedTypeMsg = expectedArgTypeErrorMsg(expectedTypes)
 
     val errorContext = propertyValueMapOf(
         Property.FUNCTION_NAME to signature.name,

lang/test/org/partiql/lang/eval/builtins/BuiltInFunctionTestExtensions.kt

@@ -0,0 +1,49 @@
+package org.partiql.lang.eval.builtins
+
+import com.amazon.ion.Timestamp
+import org.partiql.lang.ION
+import org.partiql.lang.eval.Bindings
+import org.partiql.lang.eval.EvaluationSession
+import org.partiql.lang.eval.ExprValue
+import org.partiql.lang.eval.ExprValueFactory
+import org.partiql.lang.util.newFromIonText
+
+/**
+ * Internal function used by ExprFunctionTest to test invalid argument type.
+ */
+internal val invalidArgTypeChecker = InvalidArgTypeChecker()
+internal fun checkInvalidArgType(funcName: String, syntaxSuffix: String = "(", args: List<Argument>) =
+    invalidArgTypeChecker.checkInvalidArgType(funcName, syntaxSuffix, args)
+
+/**
+ * Internal function used by ExprFunctionTest to test invalid arity.
+ */
+internal val invalidArityChecker = InvalidArityChecker()
+internal fun checkInvalidArity(funcName: String, minArity: Int, maxArity: Int) =
+    invalidArityChecker.checkInvalidArity(funcName, minArity, maxArity)
+
+private val valueFactory = ExprValueFactory.standard(ION)
+
+private fun String.toExprValue(): ExprValue = valueFactory.newFromIonText(this)
+
+private fun Map<String, String>.toBindings(): Bindings<ExprValue> = Bindings.ofMap(mapValues { it.value.toExprValue() })
+
+/**
+ * Internal function used by ExprFunctionTest to build EvaluationSession.
+ */
+internal fun Map<String, String>.toSession() = EvaluationSession.build { globals([email protected]()) }
+
+/**
+ * Internal function used by ExprFunctionTest to build EvaluationSession with now.
+ */
+internal fun buildSessionWithNow(numMillis: Long, localOffset: Int) =
+    EvaluationSession.build { now(Timestamp.forMillis(numMillis, localOffset)) }
+
+/**
+ * Used by ExprFunctionTest to represent a test case.
+ */
+data class ExprFunctionTestCase(
+    val source: String,
+    val expected: String,
+    val session: EvaluationSession = EvaluationSession.standard()
+)