Merge pull request #1432 from johnedquinn/v1-conformance-agg-signatures

Updates AVG to return DECIMAL

Author: johnedquinn

partiql-planner/src/test/kotlin/org/partiql/planner/internal/typer/PlanTyperTestsPorted.kt

@@ -3317,8 +3317,8 @@ class PlanTyperTestsPorted {
                             "min_b" to StaticType.INT4.asNullable(),
                             "max_a" to StaticType.INT4.asNullable(),
                             "max_b" to StaticType.INT4.asNullable(),
-                            "avg_a" to StaticType.INT4.asNullable(),
-                            "avg_b" to StaticType.INT4.asNullable(),
+                            "avg_a" to StaticType.DECIMAL.asNullable(),
+                            "avg_b" to StaticType.DECIMAL.asNullable(),
                         ),
                         contentClosed = true,
                         constraints = setOf(

partiql-spi/src/main/kotlin/org/partiql/spi/connector/sql/builtins/AggAvg.kt

@@ -10,6 +10,7 @@ import org.partiql.spi.fn.FnExperimental
 import org.partiql.spi.fn.FnParameter
 import org.partiql.value.PartiQLValueExperimental
 import org.partiql.value.PartiQLValueType.ANY
+import org.partiql.value.PartiQLValueType.DECIMAL
 import org.partiql.value.PartiQLValueType.DECIMAL_ARBITRARY
 import org.partiql.value.PartiQLValueType.FLOAT32
 import org.partiql.value.PartiQLValueType.FLOAT64
@@ -24,79 +25,79 @@ public object Agg_AVG__INT8__INT8 : Agg {
 
     override val signature: AggSignature = AggSignature(
         name = "avg",
-        returns = INT8,
+        returns = DECIMAL,
         parameters = listOf(
             FnParameter("value", INT8),
         ),
         isNullable = true,
         isDecomposable = true
     )
 
-    override fun accumulator(): Agg.Accumulator = AccumulatorAvg(INT8)
+    override fun accumulator(): Agg.Accumulator = AccumulatorAvg(DECIMAL)
 }
 
 @OptIn(PartiQLValueExperimental::class, FnExperimental::class)
 public object Agg_AVG__INT16__INT16 : Agg {
 
     override val signature: AggSignature = AggSignature(
         name = "avg",
-        returns = INT16,
+        returns = DECIMAL,
         parameters = listOf(
             FnParameter("value", INT16),
         ),
         isNullable = true,
         isDecomposable = true
     )
 
-    override fun accumulator(): Agg.Accumulator = AccumulatorAvg(INT16)
+    override fun accumulator(): Agg.Accumulator = AccumulatorAvg(DECIMAL)
 }
 
 @OptIn(PartiQLValueExperimental::class, FnExperimental::class)
 public object Agg_AVG__INT32__INT32 : Agg {
 
     override val signature: AggSignature = AggSignature(
         name = "avg",
-        returns = INT32,
+        returns = DECIMAL,
         parameters = listOf(
             FnParameter("value", INT32),
         ),
         isNullable = true,
         isDecomposable = true
     )
 
-    override fun accumulator(): Agg.Accumulator = AccumulatorAvg(INT32)
+    override fun accumulator(): Agg.Accumulator = AccumulatorAvg(DECIMAL)
 }
 
 @OptIn(PartiQLValueExperimental::class, FnExperimental::class)
 public object Agg_AVG__INT64__INT64 : Agg {
 
     override val signature: AggSignature = AggSignature(
         name = "avg",
-        returns = INT64,
+        returns = DECIMAL,
         parameters = listOf(
             FnParameter("value", INT64),
         ),
         isNullable = true,
         isDecomposable = true
     )
 
-    override fun accumulator(): Agg.Accumulator = AccumulatorAvg(INT64)
+    override fun accumulator(): Agg.Accumulator = AccumulatorAvg(DECIMAL)
 }
 
 @OptIn(PartiQLValueExperimental::class, FnExperimental::class)
 public object Agg_AVG__INT__INT : Agg {
 
     override val signature: AggSignature = AggSignature(
         name = "avg",
-        returns = INT,
+        returns = DECIMAL_ARBITRARY,
         parameters = listOf(
             FnParameter("value", INT),
         ),
         isNullable = true,
         isDecomposable = true
     )
 
-    override fun accumulator(): Agg.Accumulator = AccumulatorAvg(INT)
+    override fun accumulator(): Agg.Accumulator = AccumulatorAvg(DECIMAL_ARBITRARY)
 }
 
 @OptIn(PartiQLValueExperimental::class, FnExperimental::class)
@@ -152,13 +153,13 @@ public object Agg_AVG__ANY__ANY : Agg {
 
     override val signature: AggSignature = AggSignature(
         name = "avg",
-        returns = ANY,
+        returns = DECIMAL_ARBITRARY,
         parameters = listOf(
             FnParameter("value", ANY),
         ),
         isNullable = true,
         isDecomposable = true
     )
 
-    override fun accumulator(): Agg.Accumulator = AccumulatorAvg()
+    override fun accumulator(): Agg.Accumulator = AccumulatorAvg(DECIMAL_ARBITRARY)
 }