Skip to content

Commit 557eea0

Browse files
glemaitrerth
authored andcommitted
FIX add hyperlink to log when submission failed (#576)
* FIX add hyperlink to log when submission failed * debug * Update ramp-database/ramp_database/tools/tests/test_leaderboard.py * Update test_leaderboard.py * Update ramp-database/ramp_database/tools/tests/test_leaderboard.py * Update ramp-database/ramp_database/tools/tests/test_leaderboard.py
1 parent 8b8da2a commit 557eea0

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

ramp-database/ramp_database/tools/leaderboard.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ def get_leaderboard(
429429
"submission",
430430
"submitted at (UTC)",
431431
"state",
432-
"wating list",
432+
"waiting list",
433433
]
434434
else:
435435
columns = ["team", "submission", "submitted at (UTC)", "error"]
@@ -447,7 +447,7 @@ def get_leaderboard(
447447
pd.Timestamp(sub.submission_timestamp),
448448
(
449449
sub.state_with_link
450-
if leaderboard_type == "error"
450+
if leaderboard_type == "failed"
451451
else sub.state
452452
),
453453
(

ramp-database/ramp_database/tools/tests/test_leaderboard.py

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import re
12
import shutil
23

34
import pytest
@@ -170,6 +171,8 @@ def test_get_leaderboard(session_toy_db):
170171
session_toy_db, "failed", "iris_test", "test_user"
171172
)
172173
assert leaderboard_failed.count("<tr>") == 1
174+
# check that we have a link to the log of the failed submission
175+
assert re.match(r".*<a href=/.*/error.txt>.*", leaderboard_failed, flags=re.DOTALL)
173176

174177
# the remaining submission should be successful
175178
leaderboard_public = get_leaderboard(session_toy_db, "public", "iris_test")

0 commit comments

Comments
 (0)